test: ensure integration tests can fail, add vue-sfc #768
Conversation
|
Thanks for the PR, @JamesHenry! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
| @@ -70,6 +70,8 @@ export default createRule<Options, MessageIds>({ | |||
| type: 'problem', | |||
| messages: { | |||
| failure: '{{message}} (tslint:{{ruleName}})`', | |||
There was a problem hiding this comment.
This trailing ` on the message was accidentally added at some point, I will remove it once I have confirmed that the integration tests fail appropriately
|
Failed at integration test stage, as hoped, pushing update... |
|
FYI @mysticatea I have added an integration test for a Vue SFC and vue-eslint-parser. On every run (and it runs on every CI build) it will install from |
Note the first commit should hopefully cause the CI build to fail
The integration tests have been failing for a while but weren't causing CI to fail, this PR addresses that and adds an integration test for a Vue SFC as a follow up to #760