Skip to content

Conversation

@JamesHenry
Copy link
Member

Note the first commit should hopefully cause the CI build to fail

The integration tests have been failing for a while but weren't causing CI to fail, this PR addresses that and adds an integration test for a Vue SFC as a follow up to #760

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

},
type: 'problem',
messages: {
failure: '{{message}} (tslint:{{ruleName}})`',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trailing ` on the message was accidentally added at some point, I will remove it once I have confirmed that the integration tests fail appropriately

@JamesHenry
Copy link
Member Author

Failed at integration test stage, as hoped, pushing update...

@JamesHenry JamesHenry merged commit f953cbd into master Jul 28, 2019
@JamesHenry JamesHenry deleted the integration-test-improvements branch July 28, 2019 19:40
@JamesHenry
Copy link
Member Author

FYI @mysticatea I have added an integration test for a Vue SFC and vue-eslint-parser.

On every run (and it runs on every CI build) it will install from vue-eslint-parser@latest so we should catch any compatibility issues early.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants