Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile fail #48

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Fix compile fail #48

merged 10 commits into from
Oct 4, 2023

Conversation

ArtyomVancyan
Copy link
Member

@ArtyomVancyan ArtyomVancyan commented Oct 4, 2023 •
edited
Loading

Motivation:

These changes fix the issue described in #47. It also includes the necessary CI setup for tox that ensures the build's success for various versions of Ant Design.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@ArtyomVancyan
Add a build script
8b2194d 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Setup a tox tests for various environments
1cff93a 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Setup CI for running tox after tests
0a9e054 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan ArtyomVancyan linked an issue Oct 4, 2023 that may be closed by this pull request
🐛 Bug Report - fails to compile for earlier versions of antd 5 #47
Closed
@ArtyomVancyan
GH-47: Prepare package versions before tox
b547880 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Add the remaining environments
b31243d 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Use strategy matrix for environments
0bfaac2 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Use node 16 as default
f1325db 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Fix compile fail - key not exported error
b514792 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
GH-47: Add antd 5.1.0 into the environments list
646201e 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan
Upgrade the version to 0.2.3
20623ef 
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan ArtyomVancyan marked this pull request as ready for review October 4, 2023 16:54
@ArtyomVancyan ArtyomVancyan merged commit 3e489b5 into master Oct 4, 2023
@ArtyomVancyan ArtyomVancyan added the hacktoberfest-accepted Accepted by maintainers for Hacktoberfest label Oct 4, 2023
@ArtyomVancyan ArtyomVancyan deleted the fix-compile-fail branch October 4, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted by maintainers for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report - fails to compile for earlier versions of antd 5
1 participant
@ArtyomVancyan