Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept also raw values apart from phone objects #51

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

ArtyomVancyan
Copy link
Member

Motivation:

These changes implement acceptance of raw values to phone input as a value or an initial value apart from the phone object, which keeps being acceptable as a value.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
Signed-off-by: Artyom Vancyan <artyom.vancyan2000@gmail.com>
@ArtyomVancyan ArtyomVancyan marked this pull request as ready for review October 5, 2023 14:11
@ArtyomVancyan ArtyomVancyan merged commit bd0d6d4 into master Oct 5, 2023
@ArtyomVancyan ArtyomVancyan deleted the accept-raw-value branch October 5, 2023 14:11
@ArtyomVancyan ArtyomVancyan added the hacktoberfest-accepted Accepted by maintainers for Hacktoberfest label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted by maintainers for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪄 Enhancement - Accept also raw phone as a value or an initial value
1 participant