-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new isLocale validator #425
Comments
@vlapo what do u say about this |
I think we have one PR about extending error messages #238. But this is kind of advanced topic and I do not decide how to handle it, yet. |
i mean do we have something to check whether a given string is a valid language like isLanguage or isLocale ? @vlapo |
I checked validator.js but there is no such validator available perhaps we have to make a new one @vlapo |
Looks like there is FR validatorjs/validator.js#954 and PR validatorjs/validator.js#1072. I would like to wait and use validatorjs function (if PR will be merged in some reasonable time). |
@arkus7 thanks for the info. I will be doing a pr shortly |
merged but not released :D |
let md work on that
…On Mon, Mar 23, 2020 at 4:35 PM Johannes Schobel ***@***.***> wrote:
Dear @vlapo <https://github.com/vlapo> and @rubiin
<https://github.com/rubiin> ,
theisLocale() function has now been released in validatorjs 13.0.0!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6XK26KWH44GBSC2YYDYXDRI45H5ANCNFSM4I2YXEGA>
.
|
@rubiin please also create new added validators (isEthereumAddress, isIBAN, ...) |
Sure
…On Wed, Mar 25, 2020, 2:40 AM Vlad Poluch ***@***.***> wrote:
@rubiin <https://github.com/rubiin> please also create new added
validators (isEthereumAddress, isIBAN, ...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6XK2YTX7DPM2IBU67D5ZDRJEM4BANCNFSM4I2YXEGA>
.
|
@rubiin please wait with this changes. I have one big PR with lot of changes almost ready. |
@vlapo sure |
@rubiin I synced validatorjs lib to v13 (isLocale included). Thank you for help with provide this new validator. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I was working on a project that passed the language header to request the response in desired language. However I could not find it in the class-validator. How about making one. Can do a pr
The text was updated successfully, but these errors were encountered: