Please use `zh-HK` to replace `en-HK`.

[liuzhaowei55]

class-validator/src/decorator/decorators.ts

Line 972 in a98f5dd

* Checks if the string is a mobile phone number (locale is one of ['zh-CN', 'zh-TW', 'en-ZA', 'en-AU', 'en-HK',

validatorjs/validator.js#622

[vlapo]

What is a problem with en-HK?

[liuzhaowei55]

What is a problem with en-HK?

zh-HK can alo work very well
https://github.com/validatorjs/validator.js/blob/b5a1d1f23fcdd24e3ca9d6090fdc0a06fcc23d55/src/lib/isMobilePhone.js#L94

en-HK is not supported in the locale
https://en.wikipedia.org/wiki/Locale_(computer_software)

政治正确 (Politically correct)

[vlapo]

What is a problem with en-HK?

zh-HK can alo work very well
validatorjs/validator.js:src/lib/isMobilePhone.js@b5a1d1f#L94

Ok but it is not a problem.

en-HK is not supported in the locale
en.wikipedia.org/wiki/Locale_(computer_software)

Do not see any info about not supporting en-HK in locale strings

政治正确 (Politically correct)

Please do not bring politics into open-source.

I do not see any problem neither with en-HK or zh-HK as isMobilePhone accepts both of them.

[liuzhaowei55]

@vlapo
I know en-HK still run very well, bug it no longer the standard.
https://en.wikipedia.org/wiki/Locale_(computer_software)
And it is easy to cause misunderstanding, this is just a comment, why not change it to a standard?

[vlapo]

I have few reservations:

• First at all - you didnt show any proof about non-standard locale en-HK. I searched some registers and found en-HK as pretty used:
  • http://demo.icu-project.org/icu-bin/locexp?d_=en&_=en_HK
  • https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/63d3d639-7fd2-4afb-abbe-0d5b5551eef8?redirectedfrom=MSDN
  • http://www.localeplanet.com/icu/
  • https://lh.2xlibre.net/locale/en_HK/
  • https://www.ibm.com/support/knowledgecenter/en/SSS28S_8.1.0/XFDL/i_xfdl_r_formats_en_HK.html
• Second I see this just as political pressure caused by events in Hong Kong.

[liuzhaowei55]

This will be my last reply.
I only found this area code definition: https://en.m.wikipedia.org/wiki/ISO_3166-2:CN
This thing is too boring.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.