fix: context doesn't get passed with async custom validator

[dolsem]

#292 was closed and locked prematurely.

There were two PRs to fix the issue - #296 and #391. #296 was merged, but unfortunately it doesn't fix the bug that results in context not being passed when validation is performed asynchronously.

If you put async in the beginning of the following line

class-validator/test/functional/validation-options.spec.ts

Line 949 in e195025

validate(value: any, args: ValidationArguments) {

the test will fail with TypeError: Cannot read property 'isLongerThan' of undefined.

#391 was based on #296, but it did fix this bug (there was a test case included for that).

[Larsrdev]

We also ran into this problem. we need context to store some internal errorcodes, but this does not work with custom async validators.

[dolsem]

@Larsrdev I can rebase my fork off the latest master and create a new PR if maintainers express an interest in merging it.

[Larsrdev]

That would be great @dolsem. We currently cant check if a user is exisiting in database with custom async validation. And this is in my opinion a normal use case.

[Larsrdev]

I did it by myself. Thanks for your work @dolsem 👍

[vlapo]

Sorry @Larsrdev. My fault. I didn't notice your note about async validators. Could you please create PR with fix and test from actual code base?

EDIT: thnx for PR :D

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.