Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] bump repo version #2372

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[UPDATE] bump repo version #2372

merged 1 commit into from
Jan 12, 2024

Conversation

uboat46
Copy link
Contributor

@uboat46 uboat46 commented Jan 12, 2024

Description

Bump the repository version to fix validator type issues as seen on this issue

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[2370]

@sph3rex
Copy link
Contributor

sph3rex commented Jan 12, 2024

Might be a good addition, though not necessary in this PR to update the .github/workflows/continuous-deployment-workflow.yml with something like:

// current content
- run: cp README.md build/README.md
- run: |
        jq 'del(.devDependencies) | del(.scripts)' package.json > build/package.json

        release_tag=$(echo "${GITHUB_REF}" | cut -d '/' -f 3)
        package_json=$(cat build/package.json)

        if [[ "${release_tag}" != "$(jq -r '.version' <<< "${package_json}")" ]]; then
          new_version="${release_tag}"
          jq '.version = "${new_version}"' build/package.json > updated_package.json
          mv updated_package.json build/package.json
        fi
- run: npm publish ./build
        env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

so that the pipeline bumps the version before trying to push if the package.json and tag name are different.

@braaar
Copy link
Member

braaar commented Jan 12, 2024

Apologies, I am not yet familiar with the setup in this repo for publishing releases. This was my mistake

@braaar braaar merged commit 0a18ea2 into typestack:develop Jan 12, 2024
5 checks passed
@drealecs
Copy link

@braaar I think you need to recreate the tag v0.14.1 tag with the new commit, 0a18ea2.
I guess you recreated, but using the previous commit, 0042559

@sph3rex
Copy link
Contributor

sph3rex commented Jan 12, 2024

@braaar I think you need to recreate the tag v0.14.1 tag with the new commit, 0a18ea2. I guess you recreated, but using the previous commit, 0042559

Is not that, there was no npm i ran so package-lock and package.json are out of sync. 0.14.0 in package-lock.json and 0.14.1 in package.json

@braaar
Copy link
Member

braaar commented Jan 12, 2024

@drealecs is right, I need to recreate the tag

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants