Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill base64 options correctly #2549

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aseyfpour
Copy link

Description

In the IsBase64 decorator, constraints weren’t passed to isBase64. This issue has been fixed in this PR.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2548

aseyfpour and others added 2 commits November 1, 2024 15:26
pass the constraint to the isBase64 function
add unit test IsBase64 options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: base64 options doesn't apply
1 participant