fix: check if a number is NaN in ActionParameterHandler #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Param('id') id: number
is not validated and acceptsNaN
as value in case of invalidid
.For example, if the following URL is accessed (
http://example.com/users/asdf
), instead of throwing an error, theid
value is parsed toNaN
.InvalidParamError(value, parameterName, parameterType)
should be thrown instead.The problem is due to how the checking of the result of the cast operation is done.
NaN
is not equal toNaN
. Because of this it is necessary to useNumber.isNaN()
.Example
Result
GET http://example.com/users/1234
->1234
GET http://example.com/users/asdf
->NaN
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #348