Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the implementation of FlowExpressions.BinaryOperation #3474

Closed
2 tasks
smillst opened this issue Jul 14, 2020 · 2 comments · Fixed by #4195
Closed
2 tasks

Complete the implementation of FlowExpressions.BinaryOperation #3474

smillst opened this issue Jul 14, 2020 · 2 comments · Fixed by #4195

Comments

@smillst
Copy link
Member

smillst commented Jul 14, 2020 •
edited
Loading

#3397 missed the following tasks:

  • Add BinaryOperation to JavaExpression#fromTree(AnnotationProvider, ExpressionTree, boolean)
  • Document the extension of the "Java" expression language in the manual.
@smillst smillst mentioned this issue Jul 14, 2020
Open
@wmdietl
Copy link
Member

wmdietl commented Jul 15, 2020

We should also add cross-references between the internalReprOf methods mentioning that they should be kept in sync and mention the manual section in the code.

@wmdietl
Copy link
Member

wmdietl commented Jul 15, 2020

@txiang61 Can you take a look at these?

@wmdietl wmdietl mentioned this issue Jul 17, 2020
Merged
@mernst mernst linked a pull request Jan 26, 2021 that will close this issue
Define UnaryOperation, parse BinaryOperation #4195
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define UnaryOperation, parse BinaryOperation mernst/checker-framework
2 participants
@wmdietl @smillst