Improve the documentation of Receiver #3473
Conversation
dataflow/src/main/java/org/checkerframework/dataflow/analysis/FlowExpressions.java
Outdated
Show resolved
Hide resolved
dataflow/src/main/java/org/checkerframework/dataflow/analysis/FlowExpressions.java
Outdated
Show resolved
Hide resolved
dataflow/src/main/java/org/checkerframework/dataflow/analysis/FlowExpressions.java
Outdated
Show resolved
Hide resolved
docs/manual/advanced-features.tex
Outdated
| @@ -1140,7 +1140,8 @@ | |||
| \item \refqualclass{checker/lock/qual}{Holding} | |||
| \end{itemize} | |||
|
|
|||
| The set of permitted expressions is a subset of all Java expressions: | |||
| The set of permitted expressions is a subset of all Java expressions, | |||
| with a few extensions, notably \code{<self>} and formal parameters like \<\#1>. | |||
There was a problem hiding this comment.
Same concern about <self> as above.
There was a problem hiding this comment.
It is important to include <self> here, because this section is about the Checker Framework Java expression syntax.
There was a problem hiding this comment.
But it is only the Lock Checker that supports the <self> expression: https://github.com/typetools/checker-framework/blob/master/checker/src/main/java/org/checkerframework/checker/lock/LockVisitor.java#L78
So it seems rather confusing to include it like it is a generally supported expression.
There was a problem hiding this comment.
I added a qualifier to its description.
|
|
||
| Additionally, it is not possible to write | ||
| quantification over all array components (e.g. to express that all | ||
| It is not possible to write a |
There was a problem hiding this comment.
Aren't at least comparisons still forbidden? Or is this partially addressing #3474?
There was a problem hiding this comment.
Binary operations are possible, so I'm not positive that comparisons are explicitly forbidden. Since part of the list became out of date, I removed it so that the rest does not get out of date.
There was a problem hiding this comment.
Ok, so let's leave it for #3474 to add proper restrictions again.
|
|
||
| Additionally, it is not possible to write | ||
| quantification over all array components (e.g. to express that all | ||
| It is not possible to write a |
There was a problem hiding this comment.
Ok, so let's leave it for #3474 to add proper restrictions again.
No description provided.