Add Annotation File Utilities as an included build. #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillst
changed the title
smillst
commented
May 28, 2020
settings.gradle
Outdated
| @@ -6,4 +6,10 @@ include 'framework' | |||
| include 'checker-qual' | |||
| include 'checker-qual-android' | |||
| include 'framework-test' | |||
|
|
|||
| includeBuild ('../annotation-tools/annotation-file-utilities'){ | |||
| if(!file('../annotation-tools/annotation-file-utilities').exists()) { | |||
wmdietl
approved these changes
May 28, 2020
mernst
approved these changes
May 28, 2020
framework/build.gradle
Outdated
|
|
||
| // TODO: The annotated version of Guava gives an error: | ||
| // org.checkerframework.annotatedlib/guava/.../guava-28.2-jre.jar(/com/google/common/collect/ImmutableCollection.class): | ||
| // warning: Cannot find annotation method 'value()' in type 'DoNotMock': class file for com.google.errorprone.annotations.DoNotMock not found |
There was a problem hiding this comment.
This seems to be a bug in how the annotated version of Guava was made. I don't understand it yet.
In the meanwhile, can you try the workaround used in AFU, which is to add a dependency on error_prone_annotations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change it was possible to use dependencies of AFU without specifying them in the build files.