Correct the logic of dataflow framework. #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add exception block's predecessor exception block to inputs (fix null pointer exception). 2. When running runAnalysisFor() with an exception block, pass a copied transfer input to callTransferFunction(). ForwardAnalysis: 1. When running runAnalysisFor() with an exception block, pass a copied transfer input to callTransferFunction().
|
This can wait until after the release. |
|
Sorry, this is closed by accident. |
xingweitian
commented
Jul 8, 2020
wmdietl
approved these changes
Jul 20, 2020
smillst
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackwardAnalysis:
runAnalysisFor()with an exception block, pass a copied transfer input tocallTransferFunction().ForwardAnalysis:
runAnalysisFor()with an exception block, pass a copied transfer input tocallTransferFunction(). In the previous dataflow framework (before Introduce backward analysis to dataflow framework. #3370), we passed a non-copied transfer input (https://github.com/typetools/checker-framework/pull/3370/files#diff-d4108228a0a5407e00c090c2e97d8b6dL401-L402). This seems a bug existing in the old dataflow framework.Resolves #3447.