Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle widening primitive conversions #3680

Closed
wants to merge 67 commits into from
Closed

Handle widening primitive conversions #3680

wants to merge 67 commits into from

Conversation

mernst
Copy link
Member

@mernst mernst commented Sep 23, 2020 •
edited
Loading

Merge after #3678 and #3679.

The main changes are to add a @SignedPositiveFromUnsigned annotation and to add logic related to the widening that Java automatically does at arithmetic operations.

mernst added 30 commits September 18, 2020 11:57
@mernst
Documentation improvements
529ce0b
@mernst
Move typeFromClass from AnnotationBuilder to TypesUtils.
dd115bb
@mernst
Merge ../checker-framework-fork-mernst-branch-signedness-get-widened-…
38db493 
…primitive into signedness-pre-documentation
@mernst
Make unboxPrimitive return null rather than relying on undocumented b…
6ac39c9 
…ehavior
@mernst
Merge ../checker-framework-fork-mernst-branch-signedness-pre-move-typ…
66f7d36 
…eFromClass into signedness-pre-all
@mernst
Merge ../checker-framework-fork-mernst-branch-signedness-pre-unboxPri…
5ca06db 
…mitive-null into signedness-pre-all
@mernst
Move typeFromClass from AnnotationBuilder to TypesUtils.
7b839c8
@mernst
Handle widening conversions
a0ac080
@mernst
Merge ../checker-framework-fork-mernst-branch-signedness-pre-all into…
0d50205 
… signedness-get-widened-primitive
@mernst
Checkpoint
3c56f3a
@mernst
Merge ../checker-framework-branch-master into signedness-get-widened-…
fd6b3e8 
…primitive
@mernst
Fix cut-and-paste errors, add diagnostic output
b39bbc0
@mernst
Merge ../checker-framework-branch-master into signedness-get-widened-…
55b20ef 
…primitive
@mernst
Checkpoint
a78ebfc
@mernst
Add documentation
4eeb292
@mernst
Merge ../checker-framework-branch-master into signedness-get-widened-…
c38086c 
…primitive
@mernst
Distinguish between TreeAnnotator and TypeAnnotator
d47d20b
@mernst
Refactor NumberUtils into TypesUtils and TypeKindUtils
0875744
@mernst
Add another test
558a686
@mernst
Pass WideningConversion3 test
0288741
@mernst
Add tests
baef0d9
@mernst
Pass WideningConversion2 test case
d8bdfa0
@mernst
Remove unneeded code
6659345
@mernst
Pass more tests
eac2db5
@mernst
Widen types in binary operations
7feec1d
@mernst
Remove unneeded code
a380d7a
@mernst
Add diagnostics
376c667
@mernst
Remove unneeded code
09c9eb4
@mernst
Pass all tests
4a276a7
@mernst
Remove dead code, add comment
d43636d
@mernst mernst linked an issue Sep 23, 2020 that may be closed by this pull request
Signedness Checker prohibits comparisons between chars #3669
Closed
@mernst mernst linked an issue Sep 23, 2020 that may be closed by this pull request
Signedness Checker unable to know signedness of cast Object assigned to integral type #3668
Closed
@smillst smillst assigned mernst and unassigned smillst Sep 23, 2020
@mernst mernst assigned smillst and unassigned mernst Sep 24, 2020
@smillst smillst assigned mernst and unassigned smillst Sep 24, 2020
@mernst
Copy link
Member Author

mernst commented Sep 24, 2020

Will reopen later.

@mernst mernst closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mernst mernst

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mernst @smillst