Add fields for Scanners in DependentTypesHelper #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
approved these changes
Feb 9, 2021
| /** | ||
| * A scanner that standardizes Java expression strings in dependent type annotations. Call | ||
| * {@link StandardizeTypeAnnotator#init(JavaExpressionContext, TreePath, boolean, boolean)} | ||
| * before using. |
There was a problem hiding this comment.
Please clarify whether this means to call init once, or to call init before each use.
|
|
||
| /** | ||
| * Copies annotations that might have been viewpoint adapted from the visited type (the first | ||
| * formal parameter of the visit method) to the second formal parameter. |
There was a problem hiding this comment.
Is this the visit method of this class, or of the field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanners have HashMaps that can use a lot of memory, so it's better to use fields rather than creating a new object for each use. #3851 shows how a scanner caused problems else where. (#4252 is a new issue to document this problem and find more scanners to move to fields.)