-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified instructions to use Maven to make it easier for Maven users #461
Conversation
|
||
\end{enumerate} | ||
|
||
%% Of historical interest only. | ||
%% Of historical interest only. TODO: update this note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not sure how you want to update this note...
<plugin> | ||
<artifactId>maven-compiler-plugin</artifactId> | ||
<configuration> | ||
<source>1.8</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 3.3
Hi Renato. We would like to merge these instructions into the manual.
Could you please make these changes? Then we can test the instructions again, and when the instructions work for everyone, we can push them to the mainline. Thanks! |
Hi @mernst . I've been busy with my job and side-projects... so I haven't had time to do this yet. I will try to do it, but it feels like an incomplete solution knowing it won't work for Java 7... anyway, I will try to find time this week to do this. |
<groupId>org.checkerframework</groupId> | ||
<artifactId>jdk8</artifactId> | ||
<version>\ReleaseVersion{}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need one more dependency: a dependency on the 'compiler' artifact (same groupId: org.checkerframework, same version).
Good news! I got the instructions to work against JDK 7 using our Java 8 compiler jar. All that was missing from my additional instructions was to specify a dependency on the compiler jar. I tried it on your demo project and on Guava and it worked on both. |
Modified instructions to use Maven to make it easier for Maven users
I only modified the Maven instructions file in the manual...
I've created a simple project on GitHub to test this:
https://github.com/renatoathaydes/checker-maven-demo/tree/master
If you're happy with this, then I'll also update the Gradle instructions to be in line with the Maven instructions.