Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified instructions to use Maven to make it easier for Maven users #461

Merged
merged 1 commit into from
Nov 9, 2015

Conversation

renatoathaydes
Copy link

I only modified the Maven instructions file in the manual...

I've created a simple project on GitHub to test this:

https://github.com/renatoathaydes/checker-maven-demo/tree/master

If you're happy with this, then I'll also update the Gradle instructions to be in line with the Maven instructions.


\end{enumerate}

%% Of historical interest only.
%% Of historical interest only. TODO: update this note
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure how you want to update this note...

<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 3.3

@mernst
Copy link
Member

mernst commented Oct 19, 2015

Hi Renato. We would like to merge these instructions into the manual.
However, there are still some remaining issues.

  • There are a number of textual edits that need to be applied.
  • The proposed instructions don't work for Java 7. This needs to be clarified. The current patch replaces the existing instructions, but instead it should retain the existing instructions and also add new ones, indicating that users should use whichever one is appropriate for their situation. For examples, if you want to use annotations in comments, then you have to use the current instructions rather than these new ones.

Could you please make these changes? Then we can test the instructions again, and when the instructions work for everyone, we can push them to the mainline.

Thanks!

@renatoathaydes
Copy link
Author

Hi @mernst . I've been busy with my job and side-projects... so I haven't had time to do this yet.

I will try to do it, but it feels like an incomplete solution knowing it won't work for Java 7... anyway, I will try to find time this week to do this.

<groupId>org.checkerframework</groupId>
<artifactId>jdk8</artifactId>
<version>\ReleaseVersion{}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need one more dependency: a dependency on the 'compiler' artifact (same groupId: org.checkerframework, same version).

@jthaine
Copy link
Contributor

jthaine commented Oct 20, 2015

Good news! I got the instructions to work against JDK 7 using our Java 8 compiler jar. All that was missing from my additional instructions was to specify a dependency on the compiler jar. I tried it on your demo project and on Guava and it worked on both.
Renato, I think the instructions are good to go if you make the adjustments I mentioned. I also e-mailed you an updated pom.xml for your demo project that works with JDK 7.

jthaine added a commit that referenced this pull request Nov 9, 2015
Modified instructions to use Maven to make it easier for Maven users
@jthaine jthaine merged commit 3ab87fe into typetools:master Nov 9, 2015
wmdietl added a commit to flo2702/checker-framework that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants