Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsoundess in Resource Leak Checker related to owning fields and EnsuresCalledMethods #4869

Merged
merged 25 commits into from
Aug 17, 2021
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a8b7ac6
test case
kelloggm Jul 26, 2021
1257d46
another test case
kelloggm Jul 26, 2021
b773b14
remove class file
kelloggm Jul 26, 2021
6caab86
fix false negative in RLC related to owning fields and EnsuresCalledM…
kelloggm Jul 28, 2021
0b0a9f0
Merge branch 'master' of github.com:typetools/checker-framework into …
kelloggm Jul 28, 2021
6875cc9
Merge branch 'master' of github.com:typetools/checker-framework into …
kelloggm Jul 29, 2021
06c632c
test for circular field reasoning
kelloggm Jul 29, 2021
04b08cf
Merge branch 'master' of github.com:typetools/checker-framework into …
kelloggm Jul 29, 2021
82a0c64
stopping for the day
kelloggm Jul 30, 2021
a75c74d
go back to the version that uses just the exceptional exit store
kelloggm Jul 30, 2021
a19ea5d
WIP
msridhar Aug 5, 2021
27f4945
something basic working
msridhar Aug 5, 2021
4bbe5f1
docs
msridhar Aug 5, 2021
76c94db
fix CI failures
msridhar Aug 5, 2021
459bf6c
Merge branch 'master' of github.com:typetools/checker-framework into …
kelloggm Aug 6, 2021
b3ee4d9
Merge branch 'dataflow-ignore-exception-types' of github.com:msridhar…
kelloggm Aug 6, 2021
568677a
handle runtime exceptions
kelloggm Aug 6, 2021
69ecee5
remove unrelated changes
kelloggm Aug 6, 2021
27adf1e
the rest of the unrelated changes
kelloggm Aug 6, 2021
40d0294
fix docs
kelloggm Aug 6, 2021
a3642ed
Merge branch 'master' of github.com:typetools/checker-framework into …
kelloggm Aug 9, 2021
ad1da5c
add a passing test
kelloggm Aug 9, 2021
225b902
merge
kelloggm Aug 16, 2021
e906243
revert change that manu's PR used to include
kelloggm Aug 16, 2021
a00cbe9
extract out a helper method
kelloggm Aug 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix CI failures
msridhar committed Aug 5, 2021
commit 76c94db7d0de32a25ad5012cecfa65868761a1bf
Original file line number Diff line number Diff line change
@@ -11,13 +11,17 @@
*/
public class CalledMethodsAnalysis extends CFAnalysis {

/**
* Creates a new {@code CalledMethodsAnalysis}.
*
* @param checker the checker
* @param factory the factory
*/
protected CalledMethodsAnalysis(
BaseTypeChecker checker, CalledMethodsAnnotatedTypeFactory factory) {
super(checker, factory);
}

private static final String NPE_NAME = NullPointerException.class.getCanonicalName();

/**
* Ignore exceptional control flow due to {@code NullPointerException}s, as this checker assumes
* the Nullness Checker will be used to prevent such exceptions.
@@ -28,6 +32,9 @@ protected CalledMethodsAnalysis(
*/
@Override
protected boolean isIgnoredExceptionType(TypeMirror exceptionType) {
return ((Type) exceptionType).tsym.getQualifiedName().contentEquals(NPE_NAME);
return ((Type) exceptionType)
.tsym
.getQualifiedName()
.contentEquals("java.lang.NullPointerException");
}
}
Original file line number Diff line number Diff line change
@@ -27,8 +27,6 @@ void testMultiMethodParamsCorrect2(@Owning InputStream in1, @Owning InputStream
}
}

// It's a FP, see: https://github.com/typetools/checker-framework/issues/4843
// :: error: required.method.not.called
void testMultiMethodParamsCorrect3(@Owning InputStream in1, @Owning InputStream in2)
throws IOException {