Correct treatment of T extends Object and ? extends Object in stub files
#5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # framework/src/main/java/org/checkerframework/framework/util/defaults/QualifierDefaults.java
# Conflicts: # framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java # framework/src/main/java/org/checkerframework/framework/type/typeannotator/PropagationTypeAnnotator.java # framework/src/main/java/org/checkerframework/framework/util/AnnotatedTypes.java # framework/src/main/java/org/checkerframework/framework/util/defaults/QualifierDefaults.java
|
We are going to do this differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #5688
When
T extends Objector? extends Objectappear in stub files they should be treated the same as if they were written in source code. To implement this, this pull request adds code to store whetherextends Objectwas written in a stub file. Then the defaulting code uses this information.One complication of this is adding an explicit bound changes the defaulting for all type systems. That's why the type check test is failing. So, I'm not sure how we want to handle this.
Fixes #3030 and fixes #3236.