All types are immutable for nullness. Field visibility shouldn't matter. #6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Werner Dietl <wdietl@gmail.com>
|
Fixes #4923 |
smillst
previously approved these changes
Jul 15, 2024
| @@ -487,14 +487,16 @@ private boolean isExpressionOrStatementPure( | |||
| * @param classTree the class that contains {@code methodTree} | |||
| * @param methodTree the method or constructor tree | |||
| */ | |||
| // TODO: should field visibility matter? An access from outside the class might observe | |||
| // the declared type instead of a refined type. Issue a warning to alert users? | |||
| private void addInitialFieldValues(S store, ClassTree classTree, MethodTree methodTree) { | |||
| boolean isConstructor = TreeUtils.isConstructor(methodTree); | |||
| TypeElement classEle = TreeUtils.elementFromDeclaration(classTree); | |||
| for (FieldInitialValue<V> fieldInitialValue : analysis.getFieldInitialValues()) { | |||
| VariableElement varEle = fieldInitialValue.fieldDecl.getField(); | |||
| // Insert the value from the initializer of private final fields. | |||
There was a problem hiding this comment.
This comment is now incorrect. I would move the TODO that's on the method to here.
…7c00e675b091b36291cb64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4923
Co-authored-by: Werner Dietl wdietl@gmail.com