Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SuperReference #6910

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Handle SuperReference #6910

merged 6 commits into from
Dec 10, 2024

Conversation

mernst
Copy link
Member

@mernst mernst commented Dec 7, 2024

I tried to create a standalone test case, but I was not able to.

Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dataflow is treating ThisReference and SuperReference the same, which seems right to me. The code would be a bit clearer if handing the two were combined.

else if (expr instanceof ThisReference || expr instanceof SuperReference)

@smillst smillst assigned mernst and unassigned smillst Dec 9, 2024
@mernst mernst assigned smillst and unassigned mernst Dec 9, 2024
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smillst smillst enabled auto-merge (squash) December 9, 2024 21:09
@smillst smillst merged commit 7f96184 into typetools:master Dec 10, 2024
36 checks passed
@smillst smillst deleted the super-thisexpression branch December 10, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants