The primary annotation on an intersection type is the GLB of the prim… #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary annotations of the bounds.
|
Looks good to me. |
wmdietl
reviewed
Oct 3, 2016
| * The primary annotation on an intersection type is the GLB of the primary annotations | ||
| * of the bounds. | ||
| * <p> | ||
| * Example (java) subtyping relationship:<br> |
| @@ -2081,6 +2082,14 @@ public AnnotatedTypeMirror getErased() { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * The primary annotation on an intersection type is the GLB of the primary annotations | |||
| * of the bounds. | |||
There was a problem hiding this comment.
Also say that there is no syntax to explicitly write the primary annotations in source code.
| @@ -2101,6 +2110,36 @@ private AnnotatedIntersectionType( | |||
| } | |||
|
|
|||
| @Override | |||
| public Set<AnnotationMirror> getAnnotations() { | |||
| Set<AnnotationMirror> glbs = null; | |||
There was a problem hiding this comment.
What is the relationship between the value of the annotations field and the result of this method?
So far, the two were interchangeable. I'm a bit fearful of removing the final on the parent method and allowing such overrides. You changed one use of annotations to the method call. Are there others that should be changed?
|
Status update: I'm still considering how to address Werner's feedback. (Specifically #928 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary annotation on an intersection type is the GLB of the primary annotations of the bounds (a.k.a direct super types). Calling addAnnotation on an annotated intersection type adds that annotation to any bound that does not have an annotation in that hierarchy. (Tested on daikon-typecheck)
(More clean up of intersections is required in the rest of the code, but this must wait until LUB(#643) is corrected.)
Fixes #868