[WIP] Exposing curl_version_info to ruby, supports_asynch_dns? helper #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still work in progress? |
|
@i0rek I'm not 100% sure about it anymore. I think it could be merged, and would then allow proper feature detection. I'm not sure if that's actually needed/wanted. If it's not really needed it could also just be dropped/closed, I don't see any reason for lugging around code that is not used. |
|
Thanks. I like it better than what there is right now. |
hanshasselberg
added a commit
that referenced
this pull request
Jun 9, 2015
[WIP] Exposing curl_version_info to ruby, supports_asynch_dns? helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to improve the timeout handling in typhoeus. It exposes curl_version_info and uses it to provide a supports_timeout_ms? helper. This still needs verification The benefit over just checking for c-ares in the version string (in addition to using the proper api to query it) is that it should also work for the threaded resolver and other (future) async resolvers.