using controller response struct pattern

app/controller/book_controller.go

@@ -1,7 +1,6 @@
 package controller
 
 import (
- "fmt"
  "net/http"
  "strconv"
 
@@ -16,6 +15,7 @@ import (
 // BookController is controller to book entity
 type BookController struct {
  dig.In
+ BookControllerResponse
  service.BookService
 }
 
@@ -37,14 +37,14 @@ func (c *BookController) Create(ctx echo.Context) (err error) {
  }
  err = validator.New().Struct(book)
  if err != nil {
- return invalidMessage(ctx, err)
+ return c.invalidMessage(ctx, err)
  }
  ctx0 := ctx.Request().Context()
  result, err := c.BookService.Insert(ctx0, book)
  if err != nil {
  return err
  }
- return insertSuccess(ctx, result)
+ return c.insertSuccess(ctx, result)
 }
 
 // List of book
@@ -61,15 +61,15 @@ func (c *BookController) List(ctx echo.Context) error {
 func (c *BookController) Get(ctx echo.Context) error {
  id, err := strconv.ParseInt(ctx.Param("id"), 10, 64)
  if err != nil {
- return invalidID(ctx, err)
+ return c.invalidID(ctx, err)
  }
  ctx0 := ctx.Request().Context()
  book, err := c.BookService.Find(ctx0, id)
  if err != nil {
  return err
  }
  if book == nil {
- return ctx.JSON(http.StatusNotFound, map[string]string{"message": fmt.Sprintf("book #%d not found", id)})
+ return c.bookNotFound(ctx, id)
  }
  return ctx.JSON(http.StatusOK, book)
 }
@@ -78,14 +78,14 @@ func (c *BookController) Get(ctx echo.Context) error {
 func (c *BookController) Delete(ctx echo.Context) error {
  id, err := strconv.ParseInt(ctx.Param("id"), 10, 64)
  if err != nil {
- return invalidID(ctx, err)
+ return c.invalidID(ctx, err)
  }
  ctx0 := ctx.Request().Context()
  err = c.BookService.Delete(ctx0, id)
  if err != nil {
  return err
  }
- return ctx.JSON(http.StatusOK, map[string]string{"message": fmt.Sprintf("Delete #%d done", id)})
+ return c.bookDeleted(ctx, id)
 }
 
 // Update book
@@ -96,16 +96,16 @@ func (c *BookController) Update(ctx echo.Context) (err error) {
  return err
  }
  if book.ID <= 0 {
- return invalidID(ctx, err)
+ return c.invalidID(ctx, err)
  }
  err = validator.New().Struct(book)
  if err != nil {
- return invalidMessage(ctx, err)
+ return c.invalidMessage(ctx, err)
  }
  ctx0 := ctx.Request().Context()
  err = c.BookService.Update(ctx0, book)
  if err != nil {
  return err
  }
- return ctx.JSON(http.StatusOK, map[string]string{"message": "Update success"})
+ return c.bookUpdated(ctx, book.ID)
 }

app/controller/book_controller_response.go

@@ -0,0 +1,50 @@
+package controller
+
+import (
+ "fmt"
+ "net/http"
+
+ "github.com/labstack/echo"
+ "go.uber.org/dig"
+)
+
+// BookControllerResponse is response of BookController
+type BookControllerResponse struct {
+ dig.In
+}
+
+func (BookControllerResponse) invalidMessage(ctx echo.Context, err error) error {
+ return ctx.JSON(http.StatusBadRequest, GeneralResponse{
+ Message: "Invalid Message",
+ })
+}
+
+func (BookControllerResponse) invalidID(ctx echo.Context, err error) error {
+ return ctx.JSON(http.StatusBadRequest, GeneralResponse{
+ Message: "Invalid ID",
+ })
+}
+
+func (BookControllerResponse) insertSuccess(ctx echo.Context, lastInsertID int64) error {
+ return ctx.JSON(http.StatusCreated, GeneralResponse{
+ Message: fmt.Sprintf("Success insert new record #%d", lastInsertID),
+ })
+}
+
+func (BookControllerResponse) bookNotFound(ctx echo.Context, id int64) error {
+ return ctx.JSON(http.StatusNotFound, GeneralResponse{
+ Message: fmt.Sprintf("book #%d not found", id),
+ })
+}
+
+func (BookControllerResponse) bookDeleted(ctx echo.Context, id int64) error {
+ return ctx.JSON(http.StatusOK, GeneralResponse{
+ Message: fmt.Sprintf("Delete #%d done", id),
+ })
+}
+
+func (BookControllerResponse) bookUpdated(ctx echo.Context, id int64) error {
+ return ctx.JSON(http.StatusOK, GeneralResponse{
+ Message: fmt.Sprintf("Update #%d success", id),
+ })
+}

app/controller/book_controller_test.go

@@ -195,6 +195,6 @@ func TestBookController_Update(t *testing.T) {
  rr, err := echokit.DoPUT(bookCntrl.Update, "/", `{"id": 1, "author":"some-author", "title":"some-title"}`)
  require.NoError(t, err)
  require.Equal(t, http.StatusOK, rr.Code)
- require.Equal(t, "{\"message\":\"Update success\"}\n", rr.Body.String())
+ require.Equal(t, "{\"message\":\"Update #1 success\"}\n", rr.Body.String())
  })
 }

app/controller/general_response.go

@@ -0,0 +1,6 @@
+package controller
+
+// GeneralResponse is general response
+type GeneralResponse struct {
+ Message string `json:"message"`
+}