Break circular dependencies #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: - During some development using Babel, ES6 and running tasks such as Gitbook - it became apparent that someone was loading modifications to object prototypes that would introduce properties on global prototypes that would cause circular dependencies. - Seemingly any time a circular object comes through the safeJson function, it breaks. Confident this represents a least-harm way to get things sorted - Objects with this issue _are not_ capable of going through TaffyDB at the moment, so this can't cause a change in behaviour unless someone is relying expressly on a node-crashing stack overflow issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Confident this represents a least-harm way to get things sorted - Objects with this issue are not capable of going through TaffyDB at the moment, so this can't cause a change in behaviour unless someone is relying expressly on a node-crashing stack overflow issue.