Prevents throwing errors on mobile safari #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile safari with larger datasets this lines throws error: QUOTA_EXCEEDED_ERR: DOM Exception 22: An attempt was made to add something to storage that exceeded the quota
| @@ -1278,8 +1278,7 @@ var TAFFY, exports, T; | |||
| } | |||
| if ( settings.storageName ){ | |||
| setTimeout( function () { | |||
| localStorage.setItem( 'taffy_' + settings.storageName, | |||
| JSON.stringify( TOb ) ); | |||
| try { localStorage.setItem( 'taffy_' + settings.storageName, JSON.stringify( TOb ) ); } catch(Exception) {} | |||
There was a problem hiding this comment.
Can we maintain a more readable code spacing for this, like:
try {
localStorage.setItem( 'taffy_' + settings.storageName,
JSON.stringify( TOb ) );
}
catch(Exception) {}
This will also make things easier when making changes to the same lines of code from multiple pull requests (in this case eg. https://github.com/typicaljoe/taffydb/pull/45/files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile safari with larger datasets this lines throws error:
QUOTA_EXCEEDED_ERR: DOM Exception 22: An attempt was made to add something to storage that exceeded the quota