Why "lint-staged" log is different when is triggered by husky (v6)? #968

luquera · 2021-05-14T00:44:40Z

Everything is set up correctly, according to the documentation. I'm using Windows 10.

by husky:

by npm script (running lint-staged):

Thanks!

walkerrandolphsmith · 2021-05-27T18:00:12Z

I am experiencing this as well with lint staged 11.0.0 and husky v6. In addition, when I run yarn lint-staged it updates staged files, but when committing and relying on a hook to call yarn lint-staged the changes are left un-staged and a commit is made.

Running lint-staged with the following config:
$ HUSKY_DEBUG=1 git commit -m "fix some bug"
husky (debug) - starting pre-commit...
Running lint-staged with the following config:
{
  '*.{js,ts,tsx}': 'prettier --write'
}
[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for *.{js,ts,tsx}
[STARTED] prettier --write
[SUCCESS] prettier --write
[SUCCESS] Running tasks for *.{js,ts,tsx}
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SUCCESS] Applying modifications...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...

ℹ prettier --write:
src\__tests__\utilities.test.ts 326ms
[story/5065410 9ee08d85a] fix
 1 file changed, 1 insertion(+), 1 deletion(-)

MineiToshio · 2021-06-20T15:49:00Z

Having the same issue, @luquera did you manage to solve it?

stale · 2021-08-19T16:13:55Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

luquera · 2021-09-10T15:32:30Z

Having the same issue, @luquera did you manage to solve it?

Unfortunately not yet :(

stale · 2021-11-09T16:25:53Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

FFdhorkin · 2021-11-10T17:45:40Z

Issue is still not solved

mukhlisakbr · 2021-12-17T17:39:36Z

it still not solved till now

stale · 2022-02-15T18:24:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

typicode · 2022-02-17T08:20:50Z

Not sure, but I guess it detects that the terminal aren't capable of rendering the first version and renders the second one. I imagine it's done via an env variable. I would try passing some env variable to try if it's possible to "force" the first type of rendering.

And sometimes, it's better to avoid animation and have per-line information (for example logs in Git GUIs).

I would check the dependencies that lint-staged uses for rendering the results.

That said, as far as I know, I don't think there's anything that can be done in husky's code to help with that.

TrejGun · 2022-03-10T07:58:44Z

same here

acidcrash2005 · 2022-04-26T10:38:57Z

Has anyone found resolve?

Axedyson · 2022-04-26T16:59:09Z

It worked for me before, but since yesterday I've now bumped into the same exact issue.
I'm using the windows terminal and running my project in WSL2

Axedyson · 2022-04-26T17:56:31Z

Okay it seems like this is working for me:
https://github.com/AndysonDK/syncbase/blob/main/.husky/pre-commit
But commitizen cli is still not rendered properly

valentinoli · 2022-05-04T10:28:01Z

Partially fixed in lint-staged
lint-staged/lint-staged#693 (comment)

iiroj · 2022-05-30T12:59:28Z

The issue seems to be that supports-color (code link) and colorette (code link) both use the tty.isatty(1) check from node:tty to test whether the current stdin is in fact a TTY. This is reported as false when running through a git hook (with husky), and true when directly running lint-staged.

I'm not sure what caused this to start happen, but I assume it is an update to one of:

dependencies of lint-staged (colorette, supports-color..., listr2)
husky
git itself

iiroj · 2022-06-01T07:22:03Z

For a simple reproduction, try running in your terminal:

> node -e "console.log(require('tty').isatty(1))"
true

Putting this same script into the pre-commit sh script of Husky, will print false instead:

#!/usr/bin/env sh
. "$(dirname "$0")/_/husky.sh"

node -e "console.log(require('tty').isatty(1))"

akamfoad · 2022-09-06T13:54:14Z

Hi, I have a similar issue but in my case the terminal is being exploded with repeated log output.

OS: Windows
Shell: PowerShell 7.2.6
Git Version: 2.37.1.windows.1

running

yarn lint-staged

Through git hooks (added with husky):

PowerShell.2022-09-06.16-37-59.mp4

Directly running the command:

PowerShell.2022-09-06.16-39-07.mp4

lalitlsg · 2022-09-11T18:04:59Z

If I make a commit from vscode UI, by keeping exec >/dev/tty 2>&1 in pre-commit script
It gives below error:

.husky/pre-commit: line 4: /dev/tty: Device not configured

J4v4Scr1pt · 2022-09-19T10:51:36Z

Hi, I have a similar issue but in my case the terminal is being exploded with repeated log output.
OS: Windows
Shell: PowerShell 7.2.6
Git Version: 2.37.1.windows.1
running
yarn lint-staged
Through git hooks (added with husky):

PowerShell.2022-09-06.16-37-59.mp4

Directly running the command:

PowerShell.2022-09-06.16-39-07.mp4

Exactly the same thing happens to me and my team. Can't understand why and there seems to be no working solution from what I can find.
If you check Task Manager you can also see that it spins up many Node.js instances. And the computer gets super slow. It even makes working js test to timeout.

I think this is a seroius issue that will affect usage. But Like I said I cant figure out why this accure.

Edit:
I will reference you are excellent explanation in a new issue @akamfoad.

Nick-Hopps · 2022-09-28T02:36:38Z

seems they fix it in version 2.38?

vkrol · 2022-10-05T13:01:21Z

@Nick-Hopps No, I checked it.

wherehows · 2022-10-17T07:49:24Z

If I make a commit from vscode UI, by keeping exec >/dev/tty 2>&1 in pre-commit script It gives below error:

.husky/pre-commit: line 4: /dev/tty: Device not configured

@lalitlsg

i have the same problem but after i change /dev/tty to /dev/console it works

i dont know how it works exactly but anyway it works. (ㅠ.ㅠ)

cf: https://unix.stackexchange.com/questions/692257/why-no-such-device-or-address-when-open-dev-tty-in-the-first-process/

yangliguo7 · 2022-11-14T04:06:22Z

maybe you should run your command in terminal not in VSCODE or webStrom . @wherehows

akmaldira · 2022-12-10T20:50:48Z

Hi, I have a similar issue but in my case the terminal is being exploded with repeated log output.
OS: Windows
Shell: PowerShell 7.2.6
Git Version: 2.37.1.windows.1
running
yarn lint-staged
Through git hooks (added with husky):

PowerShell.2022-09-06.16-37-59.mp4

Directly running the command:

PowerShell.2022-09-06.16-39-07.mp4

Same problem here

MrFlyHouse · 2023-02-07T12:01:14Z

If I make a commit from vscode UI, by keeping exec >/dev/tty 2>&1 in pre-commit script It gives below error:
.husky/pre-commit: line 4: /dev/tty: Device not configured

@lalitlsg

i have the same problem but after i change /dev/tty to /dev/console it works

i dont know how it works exactly but anyway it works. (ㅠ.ㅠ)

cf: https://unix.stackexchange.com/questions/692257/why-no-such-device-or-address-when-open-dev-tty-in-the-first-process/

@wherehows It works when I'm using terminal panel, but doesn't work when using the SOURCE CONTROL gui panel (commit by press 'Commit' button), do you have same problem, and do you solve it if so?

VSCode said .husky/pre-commit: line 4: /dev/console: No such device or address

wherehows · 2023-02-07T12:24:41Z

If I make a commit from vscode UI, by keeping exec >/dev/tty 2>&1 in pre-commit script It gives below error:
.husky/pre-commit: line 4: /dev/tty: Device not configured

@lalitlsg
i have the same problem but after i change /dev/tty to /dev/console it works
i dont know how it works exactly but anyway it works. (ㅠ.ㅠ)
cf: https://unix.stackexchange.com/questions/692257/why-no-such-device-or-address-when-open-dev-tty-in-the-first-process/

@wherehows It works when I'm using terminal panel, but doesn't work when using the SOURCE CONTROL gui panel (commit by press 'Commit' button), do you have same problem, and do you solve it if so?

VSCode said .husky/pre-commit: line 4: /dev/console: No such device or address

not only source control but also 'fork' tool doesnt work. i haven't solved it yet ㅠ.ㅠ

siarheiyelin · 2023-03-02T12:33:52Z

I managed to solve the issue by downgrading "lint-staged" from 13.x to 12.x

iiroj · 2023-03-05T14:26:59Z

@siarheiyelin Are you sure downgrading lint-staged fixes it? If so, I can take a look at the updates/changes in version 13 and try out if a culprit can be found.

iiroj · 2023-03-05T14:40:27Z

Can you try installing lint-staged@next (version 13.1.3) to see if it helps? I restored supports-color in place of colorette's isColorSupported util, a change that was introduced in 13.0.0.

loriswit · 2023-03-05T16:15:08Z

Can you try installing lint-staged@next (version 13.1.3) to see if it helps? I restored supports-color in place of colorette's isColorSupported util, a change that was introduced in 13.0.0.

@iiroj This fixes the repeated logs issue (as seen in #968 (comment)), but shows instead the uncolored output as described in the original post. I guess this is better than the repeated outputs, but we're basically back to where we started.

Geczy · 2023-03-08T15:18:55Z

same problem here

VSCode said .husky/pre-commit: line 4: /dev/console: No such device or address

Geczy · 2023-03-08T15:49:02Z

#968 (comment)

this comment fixed the original issue for me. i reverted my pre-commit file

webbertakken · 2023-05-09T12:54:39Z

Documented a combination of fixes in https://gist.github.com/webbertakken/c2b457d39224baf701c8de1589b61555.

Works for:

🍎 MacOS using Zsh (cli) or IDE (no tty)
💻 Ubuntu using Zsh (cli) or IDE (no tty)
🪟 Windows using Git Bash or PowerShell or IDE (no tty)

Tested with WebStorm IDE and latest git versions.

@Geczy @akmaldira @MrFlyHouse @loriswit this should solve your problems as well.

Git hooks output running using husky gives output as a plain text without animated log when npx lint-staged is used. A temporary fix of redirecting stdout and stderr taken from typicode/husky#968 (comment) works for the current version of husky and lint-staged.

This reverts commit 145923d. The workaround was taken from typicode/husky#968 (comment) which corrected the husky log output with lint-staged but lead to error "/dev/tty: No such device or address" while using semantic-release.

sbiliaiev · 2023-12-01T00:16:34Z

@webbertakken Thank you! Your script is exactly what I was looking for! I've tried settings manually FORCE_COLOR to 0 and 1 as it's written in other guides but it didn't help me.
Cheers!

mreduar · 2024-01-21T19:41:24Z

Documented a combination of fixes in https://gist.github.com/webbertakken/c2b457d39224baf701c8de1589b61555.

Works for:

🍎 MacOS using Zsh (cli) or IDE (no tty)

💻 Ubuntu using Zsh (cli) or IDE (no tty)

🪟 Windows using Git Bash or PowerShell or IDE (no tty)

Tested with WebStorm IDE and latest git versions.

@Geczy @akmaldira @MrFlyHouse @loriswit this should solve your problems as well.

Unfortunately it does not work with Windows Terminal WSL under a docker container. For example using Laravel Sail.

its-monotype · 2024-01-25T17:38:28Z

@typicode It's not fixed in v9? I'm facing the same issue...

luquera changed the title ~~Why my lint-staged output is different when is triggered by Husky?~~ Why "lint-staged" log is different when is triggered by husky? May 14, 2021

luquera changed the title ~~Why "lint-staged" log is different when is triggered by husky?~~ Why "lint-staged" log is different when is triggered by husky (v6)? May 14, 2021

walkerrandolphsmith mentioned this issue May 27, 2021

How to use husky v6 with lint-staged? #949

Closed

stale bot added wontfix and removed wontfix labels Aug 19, 2021

valentinoli referenced this issue in hestiaAI/hestialabs-experiences Aug 30, 2021

Fix lint-staged logging bug (typicode/husky#949 (comment))

ac510ec

stale bot added the wontfix label Nov 9, 2021

stale bot removed the wontfix label Nov 10, 2021

stale bot added wontfix and removed wontfix labels Feb 15, 2022

typicode mentioned this issue Apr 26, 2022

Broken stdout format logs lint-staged #1134

Closed

Axedyson mentioned this issue Apr 26, 2022

Output as plain text when running lint-staged through husky lint-staged/lint-staged#693

Closed

valentinoli added a commit to hestiaAI/hestialabs-experiences that referenced this issue May 4, 2022

chore: update lint-staged typicode/husky#968 (comment)

ae4a032

bencemagyar mentioned this issue Jun 24, 2022

ESC color block in error-log lint-staged/lint-staged#1072

Closed

J4v4Scr1pt mentioned this issue Sep 19, 2022

Terminal is being exploded with repeated log outputs #1200

Open

niloysikdar mentioned this issue Oct 15, 2022

[CI] Fix husky and lint-staged issues leopardslab/react-email#123

Closed

EnixCoda mentioned this issue Nov 8, 2022

Unexpected expansion when visiting URL of issue comment directly EnixCoda/Gitako#267

Closed

paescuj mentioned this issue Jan 4, 2023

The sourcetree error is garbled #1223

Closed

hendraaagil mentioned this issue Feb 2, 2023

fix: multiple husky print & prettier path nauvalazhar/code-design#21

Merged

iiroj mentioned this issue Mar 5, 2023

Update deps and restore "supports-color" lint-staged/lint-staged#1264

Closed

iiroj mentioned this issue Dec 1, 2023

Verbose output on windows lint-staged/lint-staged#1277

Closed

Charlie-XIAO mentioned this issue Apr 6, 2024

MAINT workaround pre-commit /dev/tty not found and fix escape error on Windows CMD CSCI-SHU-410-SE-Project/Deskulpt#8

Merged

Why "lint-staged" log is different when is triggered by husky (v6)? #968

Why "lint-staged" log is different when is triggered by husky (v6)? #968

Comments

luquera commented May 14, 2021

walkerrandolphsmith commented May 27, 2021 • edited Loading

MineiToshio commented Jun 20, 2021

stale bot commented Aug 19, 2021

luquera commented Sep 10, 2021

stale bot commented Nov 9, 2021

FFdhorkin commented Nov 10, 2021

mukhlisakbr commented Dec 17, 2021

stale bot commented Feb 15, 2022

typicode commented Feb 17, 2022

TrejGun commented Mar 10, 2022

acidcrash2005 commented Apr 26, 2022

Axedyson commented Apr 26, 2022 • edited Loading

Axedyson commented Apr 26, 2022 • edited Loading

valentinoli commented May 4, 2022 • edited Loading

iiroj commented May 30, 2022

iiroj commented Jun 1, 2022

akamfoad commented Sep 6, 2022

Through git hooks (added with husky):

Directly running the command:

lalitlsg commented Sep 11, 2022

J4v4Scr1pt commented Sep 19, 2022 • edited Loading

Through git hooks (added with husky):

Directly running the command:

Nick-Hopps commented Sep 28, 2022

vkrol commented Oct 5, 2022

wherehows commented Oct 17, 2022 • edited Loading

yangliguo7 commented Nov 14, 2022 • edited Loading

akmaldira commented Dec 10, 2022

Through git hooks (added with husky):

Directly running the command:

MrFlyHouse commented Feb 7, 2023

wherehows commented Feb 7, 2023

siarheiyelin commented Mar 2, 2023

iiroj commented Mar 5, 2023

iiroj commented Mar 5, 2023 • edited Loading

loriswit commented Mar 5, 2023 • edited Loading

Geczy commented Mar 8, 2023

Geczy commented Mar 8, 2023

webbertakken commented May 9, 2023

sbiliaiev commented Dec 1, 2023

mreduar commented Jan 21, 2024

its-monotype commented Jan 25, 2024

walkerrandolphsmith commented May 27, 2021 •

edited

Loading

Axedyson commented Apr 26, 2022 •

edited

Loading

Axedyson commented Apr 26, 2022 •

edited

Loading

valentinoli commented May 4, 2022 •

edited

Loading

J4v4Scr1pt commented Sep 19, 2022 •

edited

Loading

wherehows commented Oct 17, 2022 •

edited

Loading

yangliguo7 commented Nov 14, 2022 •

edited

Loading

iiroj commented Mar 5, 2023 •

edited

Loading

loriswit commented Mar 5, 2023 •

edited

Loading