Handle argument deconstruction in npx #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle argument deconstruction in npx npx isn't honoring quotes around the command passed to husky add<filename> command. There's currently a validation on add that prevents more than one from being passed. Removed this as it seems unnecessary, then joined the arguments after the cmd into a string to be passed to add.
|
Thanks for the PR! It seems to have been fixed by npm v7.5.4 |
|
Yeah, it looks like its working on the latest npm. I'll close this since to my mind it's a bug in npx and this PR is a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx isn't honoring quotes around the command passed to husky add command.
There's currently a validation on add that prevents more than one from being passed. Removed this as it seems unnecessary, then joined the arguments after the cmd into a string to be passed to add.
Fixes #866
Fixes #871