Add npm/big-integer #379
Merged
Add npm/big-integer #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typings URL: https://github.com/Demurgos/typed-big-integer
Questions (for new typings):
Notes:
big-integerdefines "prestored" values as constants for numbers from -999 to 999. Currently I defined these constants by generating the whole sequence, I'm not sure if there is a smarter way to do it. (I'm not even sure if Typescript recognizes it correctly, it does not complain when the number is in the range, but it does not complain either when the number is outside of the range - and I don't get auto-completion with WebStorm).+relying onvalueOfdoes not work with Typescript yet. Related issue: Allow wrapped values to be used in place of primitives. microsoft/TypeScript#2361