Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #4

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add documentation #4

merged 1 commit into from
Nov 15, 2024

Conversation

tangrufus
Copy link
Member

No description provided.

@tangrufus tangrufus marked this pull request as draft November 15, 2024 03:16
@tangrufus tangrufus marked this pull request as ready for review November 15, 2024 03:18
@tangrufus tangrufus force-pushed the doc branch 4 times, most recently from 515d693 to 69da4bb Compare November 15, 2024 06:46
@tangrufus tangrufus merged commit 7857346 into main Nov 15, 2024
4 checks passed
@tangrufus tangrufus deleted the doc branch November 15, 2024 07:04
@@ -0,0 +1,115 @@
package comver_test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangrufus This files could be renamed to doc_example_test.go (note the p)

Copy link
Member Author

@tangrufus tangrufus Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I need ☕

Please don't use this package yet. I am not satisfied with the API yet.
API changes are coming in #12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #12

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants