Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert for tests instead of visual output compare #56

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eltos
Copy link
Contributor

@eltos eltos commented Feb 13, 2025

To ease maintainability especially for new typst versions, and since the library does not actually produce visual output, the tests should use logical assertions rather than visual output comparison.

Motivation: When updating typst, few pixels will often change, causing the tests to fail, even though the output is still a "true". See #55 for an example.
It will also allow to test against multiple typst versions via CI matrix strategy.

This is just a start, mainly for tracking and as a reminder, the PR is far from complete.

@tingerrr
Copy link
Member

I don't quite remember, but I think the ci-semi-stable version of might already support compile-only tests. Otherwise, it may just be appropriate to switch to Tytanic for testing once 0.2.0 is out (should be in tandem with Typst 0.13.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants