Make EcoVec generic over choice of reference count type
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a reference count type parameter to `EcoVec<T>`, allowing it to be used with non-atomic reference counts if the vec is only being used on a single thread. I left `EcoString` non-generic over refence counts, but that could also be made generic in a future patch.
Codecov ReportPatch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
|
This idea has come up before and my thoughts are quite well expressed by this comment on a similar PR to smol_str: rust-analyzer/smol_str#37 (comment) |
|
See also discussion on the reddit post: https://www.reddit.com/r/rust/comments/117ksvr/comment/j9ek5t3/ |
That's a shame but I understand the design decision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a reference count type parameter to
EcoVec<T>, allowing it to be used with non-atomic reference counts if the vec is only being used on a single thread.I left
EcoStringnon-generic over refence counts, but that could also be made generic in a future patch.