Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note field to interop #218

Closed
wants to merge 1 commit into from
Closed

Add note field to interop #218

wants to merge 1 commit into from

Conversation

Drodt
Copy link
Contributor

@Drodt Drodt commented Oct 1, 2024

The note field of biblatex was not added to the note field of hayagriva during conversion. This PR fixes this.

@EpicEricEE
Copy link

Should this maybe rather replace the annotation in the block above? The annotation is later used for the annote field after all so it doesn't really make sense to have it twice.

@Drodt
Copy link
Contributor Author

Drodt commented Oct 1, 2024

Should this maybe rather replace the annotation in the block above? The annotation is later used for the annote field after all so it doesn't really make sense to have it twice.

Looks like you're right. But I would like confirmation by the main developers. I don't want to break things.

@reknih
Copy link
Member

reknih commented Oct 1, 2024

I'll check tomorrow. I have a hunch that our documentation of annote and note switches their meaning up vis-à-vis biblatex and possibly CSL.

By the way @Drodt, do you think you can update #105? I like the change and we will release a new Hayagriva version tomorrow.

@Drodt
Copy link
Contributor Author

Drodt commented Oct 1, 2024

By the way @Drodt, do you think you can update #105? I like the change and we will release a new Hayagriva version tomorrow.

It can be merged without errors now.

@reknih
Copy link
Member

reknih commented Oct 2, 2024

Closed in favor of #220

@reknih reknih closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants