New frontend #65
Closed
New frontend #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reknih
force-pushed
the
new-frontend
branch
from
125e4ba to
4b7f37e
Compare
laurmaedje
reviewed
Sep 29, 2023
laurmaedje
reviewed
Oct 6, 2023
Comment on lines
+95
to
99
| impl From<&[Spanned<Chunk>]> for FormatString { | ||
| fn from(chunks: &[Spanned<Chunk>]) -> Self { | ||
| Self { value: chunks.into(), short: None } | ||
| } | ||
| out | ||
| } |
There was a problem hiding this comment.
This impl feels a bit unidiomatic because it converts and implicitly clones. Is it used at all / a lot?
There was a problem hiding this comment.
Yes, a lot, for biblatex conversion
|
Superseded by #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new frontend that is more easily maintainable. A macro is the single point of definition for all entry fields and each type has to implement the
HayagrivaValuetrait for a centralized and composable approach to serialization and deserialization.This PR prepares Hayagriva for CSL ingestion and processing.
Please do not review the legacy styles.