-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
touying:0.5.3 #1086
touying:0.5.3 #1086
Conversation
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Thanks! |
@elegaanz Could we possibly add a checkbox in the pull request template for checking for correct semantic versioning? This package update contains a breaking change which is even listed in the changelog but the update is a patch: |
Thanks for the comments. Every version of touying basically contains more or less breaking changes, and it is difficult to determine whether a version is a patch or not. My current strategy is that if there's only one or so breaking changes, then I'm not going to add a major version. If you have a better idea, welcome to discuss. |
Is there a particular reason why it is undesirable to just make it |
Okay, that's probably just a difference in perception. Because every update of Touying brings a bit of a breaking update, if you add a major version whenever there is a breaking update (no matter how big or small), the last bit of the version number will not be used at all, that is, every update will not be compatible. I was thinking about whether this version should be called 0.6.0, but in the end I didn't think it was a major refactoring update like 0.5.0, so I ended up just calling it 0.5.3. I think it's a compatible version with only a small number of users need a few changes. For example, touying's example doesn't encourage you to write the slide content directly under a first-level heading, but rather encourages you to create a second-level heading that users won't run into a breaking change if they follow the examples. Even if you encounter this breaking change, I think you only need to add some |
Technically, when you are on the 0.x.y series, semantic versioning does not really have any rules, anything can break at any time. Still, it is possible to add this checkbox to the PR template. However, in general it is quite hard for reviewers to check that semver is indeed respected: you would have to diff the two versions and understand how the package works, which is just too time consuming. So the checkbox would really just be a reminder for package authors. |
@OrangeX4 Thanks for the reply! I don't personally agree but your position is totally fair enough, and perfectly reasonable. While I've got you here thanks for touying btw, I just gave a talk yesterday with slides made using it and it was a joy to use! |
@elegaanz That is precisely why I think it would be a good idea to have such a checkbox (independent of my position on this particular instance and major version zero), because it is so difficult to actually verify as a reviewer. Up to you though! |
I am submitting
Description:
Features
strecth
parameter for#alternatives[]
function class. This allows us to handle cases where the internal element is a context expression.config-common(align-enum-marker-with-baseline: true)
for aligning the enum marker with the baseline.linebreaks
option tocomponents.mini-slides
. feat: addlinebreaks
option to components.mini-slides touying-typ/touying#96<touying:skip>
label to skip a new-section-slide.config-common(show-hide-set-list-marker-none: true)
to make the markers oflist
andenum
invisible after#pause
.config-common(bibliography-as-footnote: bibliography(title: none, "ref.bib"))
to display the bibliography in footnotes.config-common(show-strong-with-alert: true)
configuration to display strong text with an alert. (small breaking change for some themes)display-current-heading
for preserving heading style in title and subtitle. [Features] Preserve heading style in title and subtitle touying-typ/touying#71new-section-slide-fn
function class can receivebody
parameter. We can usereceive-body-for-new-section-slide-fn
to control it. (Breaking change)#speaker-note[]
for a new section slide, like= Section Title \ #speaker-note[]
.---
after the section title.Fixes
enable-frozen-states-and-counters
in handout mode.square()
function. Unable to usesquare
touying-typ/touying#73show-notes-on-second-screen: bottom
. Hidden slide numbering when usingshow-notes-on-second-screen: bottom
touying-typ/touying#89touying-fn-wrapper
is broken inside agrid
touying-typ/touying#95auto-offset-for-heading
tofalse
by default.theme.simple
touying-typ/touying#70