Support Django 4.0, drop support for older Python & Django versions #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'admin' app in later versions of Django requires 'messages' middleware and not included that fails tests. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
- In Django 4.0, widget CheckboxSelectMultiple is a sub-class of RadioSelect causing the former to be rendered as the latter. Fix this by improving the check. - Versions of Django < 3.2 are no longer supported[1]. Drop support for them. Continue to support Django 2.2 has this is the version in current Debian stable (and requires no special handling). - Versions of Python < 3.7 are no longer supported[2]. Drop support for them. - Remove comments and code referring to older versions for simpler code. Links: 1) Django Supported Version: https://www.djangoproject.com/download/ 2) Python Supported Versions: https://devguide.python.org/#status-of-python-branches Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
jvalleroy
pushed a commit
to freedombox/FreedomBox
that referenced
this pull request
Jul 5, 2022
Closes: #2228. - Django 4.0 changed to using <div> instead of using <ul> and <li> for multiple choice select fields. Update code for the select-all button to work with the new HTML structure. - Add styling to ensure that multiple choice select field appears similar to previous <ul> and <li> based style. - This patch assumes that django-bootstrap-form has support for Django 4.0 as seen in tzangms/django-bootstrap-form#110 . Tests: - Radio select seem to have no issues. Checked in networks -> connection type page. - Open Backups -> Create backup page and ensure that select all button works and appears same on testing (Django 3.2) and unstable (Django 4.0). Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django 4.0, widget CheckboxSelectMultiple is a sub-class of RadioSelect
causing the former to be rendered as the latter. Fix this by improving the
check.
Versions of Django < 3.2 are no longer supported[1]. Drop support for them.
Continue to support Django 2.2 has this is the version in current Debian
stable (and requires no special handling).
Versions of Python < 3.7 are no longer supported[2]. Drop support for them.
Remove comments and code referring to older versions for simpler code.
Links:
Django Supported Version: https://www.djangoproject.com/download/
Python Supported Versions:
https://devguide.python.org/#status-of-python-branches