Char* conversion for default_value errornous when adding WiFiManagerParameter(); #1050
Comments
tablatronix
added
Question
|
You need to let c++ decide for the size: |
unfortunatly this did not work and does not change anything no matter what i do there... the error occurs when i do the following:
it is so weird that this sequence of events works totally fine till it breaks... this issue here seems to be related? |
|
Are you sure the parameters are still in scope? Maybe reduce your test sketch so we can reproduce, there is too much going on there, try the examples |
|
You are re-assigning custom_mqtt_broker in your setup pfunction , don’t do it like that. |
|
ok... progress :)
i did that and then
got rid of the weirdness... but i cant find a way to update the value of custom_mqtt_broker on runtime... so the value i get back at custom_mqtt_broker.getValue() will always be 192.168.1.108 no matter what i do in the portal and therefor the param-interface will always show that value. is there a method to do this cleanly? #include <FS.h> //this needs to be first, or it all crashes and burns...
#include <ArduinoJson.h> //https://github.com/bblanchon/ArduinoJson
#include <WiFiManager.h> //https://github.com/tzapu/WiFiManager WiFi Configuration Magic
#include <PubSubClient.h>
#include <ESP8266WiFi.h>
WiFiManager wm;
ESP8266WebServer server(80);
//############################################# CUSTOM PARAMETERS FOR THE WIFI MANAGER ##########################################
char mqtt_broker[16] = "192.168.100.108";
WiFiManagerParameter custom_mqtt_broker("mqttbroker", "MQTT Broker", mqtt_broker, 16);
//################################################### GENERAL VARIABLES #########################################################
bool blockWM = true; // Change this to false if you want your code to continue to run on the loop void even if you are not conected to any wifi.
//###############################################################################################################################
void saveParamCallback() {
Serial.println("****************Should save params");
Serial.println(mqtt_broker);
Serial.println(custom_mqtt_broker.getValue());
strcpy(mqtt_broker, custom_mqtt_broker.getValue());
Serial.println(mqtt_broker);
Serial.println(custom_mqtt_broker.getValue());
DynamicJsonDocument json(1024);
json["mqtt_broker"] = mqtt_broker;
File configFile2 = SPIFFS.open("/config.json", "w");
if (!configFile2) {
Serial.println("failed to open config file for writing");
}
serializeJson(json, Serial);
serializeJson(json, configFile2);
configFile2.close();
//end save
}
void handleNotFound()
{
String message = "File Not Found\n\n";
message += "URI: ";
message += server.uri();
message += "\nMethod: ";
message += (server.method() == HTTP_GET) ? "GET" : "POST";
message += "\nArguments: ";
message += server.args();
message += "\n";
for (uint8_t i = 0; i < server.args(); i++)
{
message += " " + server.argName(i) + ": " + server.arg(i) + "\n";
}
server.send(404, "text/plain", message);
}
/*
This void sets the device with the WiFiManager from tzapu with custom parameters.
Needs to be called only in the setup void.
*/
void setupDeviceWM()
{
//Serial.println("setupDeviceWM() is running");
// callbacks
wm.setConfigPortalBlocking(blockWM);
String ssid = "IOT_ESP_" + String(ESP.getChipId());
if (wm.autoConnect(ssid.c_str()))
{
//if you get here you have connected to the WiFi
Serial.println("Connected to wifi network!");
Serial.println(ssid);
Serial.println(WiFi.localIP());
WiFi.mode(WIFI_STA);
wm.startWebPortal();
}
else
{
Serial.println("Could not connect with WiFi!");
}
// call the code down to activate wifi so users can configure the device, event if it's connected to the local network
//wm.startConfigPortal("IOT_Device");
//
server.onNotFound(handleNotFound);
server.begin(); // declare this at the beggining of the code => ESP8266WebServer server(80);
}
/*
This void needs to be called in the loop void so it can handle the WM and the webportal.
*/
void loopDeviceWM()
{
wm.process();
server.handleClient();
}
int setupSpiffs() {
//read configuration from FS json
Serial.println("mounting FS...");
if (SPIFFS.begin()) {
Serial.println("mounted file system");
if (SPIFFS.exists("/config.json")) {
//file exists, reading and loading
Serial.println("reading config file");
File configFile = SPIFFS.open("/config.json", "r");
if (configFile) {
Serial.println("opened config file");
size_t size = configFile.size();
// Allocate a buffer to store contents of the file.
std::unique_ptr<char[]> buf(new char[size]);
configFile.readBytes(buf.get(), size);
DynamicJsonDocument jsonBuffer(1024);
deserializeJson(jsonBuffer, buf.get());
serializeJson(jsonBuffer, Serial);
if (!jsonBuffer.isNull()) {
Serial.println("\nparsed json");
strcpy(mqtt_broker, jsonBuffer["mqtt_broker"]);
Serial.println("loaded Json");
Serial.println("now mqtt broker is: ");
Serial.println(mqtt_broker);
return 0;
} else {
Serial.println("failed to load json config");
return 1;
}
configFile.close();
}
}
else
{
Serial.println("config json doesnt exist");
return 1;
}
} else {
Serial.println("failed to mount FS");
return 1;
}
//end read
}
void setup()
{
Serial.begin(115200);
delay(3000);
//diese funktion gibt 0 zurück wenn eine config json da ist.
if(setupSpiffs() == 0){
Serial.println("SO, NOW:");
Serial.println(mqtt_broker);
//custom_mqtt_broker = WiFiManagerParameter("mqttbroker", "MQTT Broker", mqtt_broker, 16);
}
else
{
}
// at this point the parameters are either empty because there is no config or full because there is a config
wm.setSaveParamsCallback(saveParamCallback);
wm.addParameter(&custom_mqtt_broker);
std::vector<const char *> menu = {"wifi", "info", "param", "close", "sep", "erase", "restart", "exit"};
wm.setMenu(menu); // custom menu, pass vector
// set country
wm.setCountry("US"); // setting wifi country seems to improve OSX soft ap connectivity, may help others as well
Serial.println("Setup mode...");
//wifiManager.resetSettings();
setupDeviceWM();
wm.setClass("invert");
Serial.println("-------------");
Serial.println(String(custom_mqtt_broker.getValue()));
Serial.println(custom_mqtt_broker.getValue());
Serial.println(String(mqtt_broker));
Serial.println(mqtt_broker);
}
void loop()
{
loopDeviceWM();
}
|
|
I have no idea, your sketch still contains other stuff not needed to reproduce, hell you have 2 webservers running... |
|
you are right - you need to know my motivation to know why i left that part in: the basic idea behind the sketch was to take the sketch posted on the end of this: and to merge it with the FS Example. i guess the question turned into |
|
i refactored and still got to the root of the problem: when i configure the first time everything is cool. after entering the configportal while on wireless with the local ip the fields are empty... therefor when i change a value in the custom parameters i rewrite the existing ones with "" - i wanted to get around of that and so my code above seems, and quite probably is, kind of weird... so here is this version for reproducing that: #include <FS.h> // this needs to be first, or it all crashes and burns...
#include <WiFiManager.h> // https://github.com/tzapu/WiFiManager
#include <ArduinoJson.h> // https://github.com/bblanchon/ArduinoJson
#ifdef ESP32
#include <SPIFFS.h>
#endif
//define your default values here, if there are different values in config.json, they are overwritten.
char mqtt_server[40];
char mqtt_port[6] = "8080";
char api_token[32] = "YOUR_API_TOKEN";
//default custom static IP
char static_ip[16] = "10.0.1.56";
char static_gw[16] = "10.0.1.1";
char static_sn[16] = "255.255.255.0";
//flag for saving data
bool shouldSaveConfig = false;
//callback notifying us of the need to save config
void saveConfigCallback () {
Serial.println("Should save config");
shouldSaveConfig = true;
}
void setupSpiffs(){
//clean FS, for testing
// SPIFFS.format();
//read configuration from FS json
Serial.println("mounting FS...");
if (SPIFFS.begin()) {
Serial.println("mounted file system");
if (SPIFFS.exists("/config.json")) {
//file exists, reading and loading
Serial.println("reading config file");
File configFile = SPIFFS.open("/config.json", "r");
if (configFile) {
Serial.println("opened config file");
size_t size = configFile.size();
// Allocate a buffer to store contents of the file.
std::unique_ptr<char[]> buf(new char[size]);
configFile.readBytes(buf.get(), size);
DynamicJsonDocument jsonBuffer(1024);
//DynamicJsonBuffer jsonBuffer;
deserializeJson(jsonBuffer, buf.get());
//JsonObject& json = jsonBuffer.parseObject(buf.get());
serializeJson(jsonBuffer, Serial);
//json.printTo(Serial);
if (!jsonBuffer.isNull()) {
Serial.println("\nparsed json");
strcpy(mqtt_server, jsonBuffer["mqtt_server"]);
strcpy(mqtt_port, jsonBuffer["mqtt_port"]);
strcpy(api_token, jsonBuffer["api_token"]);
// if(json["ip"]) {
// Serial.println("setting custom ip from config");
// strcpy(static_ip, json["ip"]);
// strcpy(static_gw, json["gateway"]);
// strcpy(static_sn, json["subnet"]);
// Serial.println(static_ip);
// } else {
// Serial.println("no custom ip in config");
// }
} else {
Serial.println("failed to load json config");
}
}
}
} else {
Serial.println("failed to mount FS");
}
//end read
}
WiFiManager wm;
WiFiManagerParameter custom_mqtt_server("server", "mqtt server", mqtt_server, 40);
WiFiManagerParameter custom_mqtt_port("port", "mqtt port", mqtt_port, 6);
WiFiManagerParameter custom_api_token("api", "api token", "", 32);
void setup() {
// put your setup code here, to run once:
Serial.begin(115200);
Serial.println();
setupSpiffs();
// WiFiManager, Local intialization. Once its business is done, there is no need to keep it around
//set config save notify callback
wm.setSaveConfigCallback(saveConfigCallback);
// setup custom parameters
//
// The extra parameters to be configured (can be either global or just in the setup)
// After connecting, parameter.getValue() will get you the configured value
// id/name placeholder/prompt default length
//add all your parameters here
wm.addParameter(&custom_mqtt_server);
wm.addParameter(&custom_mqtt_port);
wm.addParameter(&custom_api_token);
// set static ip
// IPAddress _ip,_gw,_sn;
// _ip.fromString(static_ip);
// _gw.fromString(static_gw);
// _sn.fromString(static_sn);
// wm.setSTAStaticIPConfig(_ip, _gw, _sn);
//reset settings - wipe credentials for testing
//wm.resetSettings();
//automatically connect using saved credentials if they exist
//If connection fails it starts an access point with the specified name
//here "AutoConnectAP" if empty will auto generate basedcon chipid, if password is blank it will be anonymous
//and goes into a blocking loop awaiting configuration
if (!wm.autoConnect("AutoConnectAP", "password")) {
Serial.println("failed to connect and hit timeout");
delay(3000);
// if we still have not connected restart and try all over again
ESP.restart();
delay(5000);
}
// always start configportal for a little while
// wm.setConfigPortalTimeout(60);
// wm.startConfigPortal("AutoConnectAP","password");
//if you get here you have connected to the WiFi
Serial.println("connected...yeey :)");
WiFi.mode(WIFI_STA);
wm.startWebPortal();
//read updated parameters
strcpy(mqtt_server, custom_mqtt_server.getValue());
strcpy(mqtt_port, custom_mqtt_port.getValue());
strcpy(api_token, custom_api_token.getValue());
//save the custom parameters to FS
if (shouldSaveConfig) {
Serial.println("saving config");
DynamicJsonDocument jsonBuffer(1024);
// JsonObject& json = jsonBuffer.createObject();
jsonBuffer["mqtt_server"] = mqtt_server;
jsonBuffer["mqtt_port"] = mqtt_port;
jsonBuffer["api_token"] = api_token;
// json["ip"] = WiFi.localIP().toString();
// json["gateway"] = WiFi.gatewayIP().toString();
// json["subnet"] = WiFi.subnetMask().toString();
File configFile = SPIFFS.open("/config.json", "w");
if (!configFile) {
Serial.println("failed to open config file for writing");
}
serializeJson(jsonBuffer, Serial);
serializeJson(jsonBuffer, configFile);
//jsonBuffer.prettyPrintTo(Serial);
//jsonBuffer.printTo(configFile);
configFile.close();
//end save
shouldSaveConfig = false;
}
Serial.println("local ip");
Serial.println(WiFi.localIP());
Serial.println(WiFi.gatewayIP());
Serial.println(WiFi.subnetMask());
}
void loop() {
// put your main code here, to run repeatedly:
wm.process();
}````
|
|
ok this is pretty much the example, so where exactly is the problem, where in the code can we see the issue ? can you add a line in there or serial print ? |
ok - above sketch never saved changed parameters to spiff... could not work anyway... but please try this one. there is an obvious serial print saying what i expect and this is not matching up with what i get at the end of the setup - so as you can see "mqtt_broker" is alright - i can use this to connect ... but custom_mqtt_broker.getValue() is not. and that also shows on the portal making it unusable. #include <FS.h> //this needs to be first, or it all crashes and burns...
#include <ArduinoJson.h> //https://github.com/bblanchon/ArduinoJson
#include <WiFiManager.h> //https://github.com/tzapu/WiFiManager WiFi Configuration Magic
WiFiManager wm;
//############################################# CUSTOM PARAMETERS FOR THE WIFI MANAGER ##########################################
char mqtt_broker[16] = "192.168.100.108";
WiFiManagerParameter custom_mqtt_broker("mqttbroker", "MQTT Broker", mqtt_broker, 16);
//################################################### GENERAL VARIABLES #########################################################
bool blockWM = true; // Change this to false if you want your code to continue to run on the loop void even if you are not conected to any wifi.
//###############################################################################################################################
void saveParamCallback() {
Serial.println("****************Should save params");
Serial.println(mqtt_broker);
Serial.println(custom_mqtt_broker.getValue());
strcpy(mqtt_broker, custom_mqtt_broker.getValue());
Serial.println(mqtt_broker);
Serial.println(custom_mqtt_broker.getValue());
DynamicJsonDocument json(1024);
json["mqtt_broker"] = mqtt_broker;
File configFile2 = SPIFFS.open("/config.json", "w");
if (!configFile2) {
Serial.println("failed to open config file for writing");
}
serializeJson(json, Serial);
serializeJson(json, configFile2);
configFile2.close();
//end save
}
/*
This void sets the device with the WiFiManager from tzapu with custom parameters.
Needs to be called only in the setup void.
*/
void setupDeviceWM()
{
//Serial.println("setupDeviceWM() is running");
// callbacks
wm.setConfigPortalBlocking(blockWM);
String ssid = "IOT_ESP_" + String(ESP.getChipId());
if (wm.autoConnect(ssid.c_str()))
{
//if you get here you have connected to the WiFi
Serial.println("Connected to wifi network!");
Serial.println(ssid);
Serial.println(WiFi.localIP());
WiFi.mode(WIFI_STA);
wm.startWebPortal();
}
else
{
Serial.println("Could not connect with WiFi!");
}
// call the code down to activate wifi so users can configure the device, event if it's connected to the local network
//wm.startConfigPortal("IOT_Device");
//
}
/*
This void needs to be called in the loop void so it can handle the WM and the webportal.
*/
void loopDeviceWM()
{
wm.process();
}
int setupSpiffs() {
//read configuration from FS json
Serial.println("mounting FS...");
if (SPIFFS.begin()) {
Serial.println("mounted file system");
if (SPIFFS.exists("/config.json")) {
//file exists, reading and loading
Serial.println("reading config file");
File configFile = SPIFFS.open("/config.json", "r");
if (configFile) {
Serial.println("opened config file");
size_t size = configFile.size();
// Allocate a buffer to store contents of the file.
std::unique_ptr<char[]> buf(new char[size]);
configFile.readBytes(buf.get(), size);
DynamicJsonDocument jsonBuffer(1024);
deserializeJson(jsonBuffer, buf.get());
serializeJson(jsonBuffer, Serial);
if (!jsonBuffer.isNull()) {
Serial.println("\nparsed json");
strcpy(mqtt_broker, jsonBuffer["mqtt_broker"]);
Serial.println("loaded Json");
Serial.println("now mqtt broker is: ");
Serial.println(mqtt_broker);
return 0;
} else {
Serial.println("failed to load json config");
return 1;
}
configFile.close();
}
}
else
{
Serial.println("config json doesnt exist");
return 1;
}
} else {
Serial.println("failed to mount FS");
return 1;
}
//end read
}
void setup()
{
Serial.begin(115200);
delay(3000);
//diese funktion gibt 0 zurück wenn eine config json da ist.
if(setupSpiffs() == 0){
Serial.println("SO, NOW:");
Serial.println(mqtt_broker);
//custom_mqtt_broker = WiFiManagerParameter("mqttbroker", "MQTT Broker", mqtt_broker, 16);
}
else
{
}
// at this point the parameters are either empty because there is no config or full because there is a config
wm.setSaveParamsCallback(saveParamCallback);
wm.addParameter(&custom_mqtt_broker);
std::vector<const char *> menu = {"wifi", "info", "param", "close", "sep", "erase", "restart", "exit"};
wm.setMenu(menu); // custom menu, pass vector
// set country
wm.setCountry("US"); // setting wifi country seems to improve OSX soft ap connectivity, may help others as well
Serial.println("Setup mode...");
//wifiManager.resetSettings();
setupDeviceWM();
wm.setClass("invert");
Serial.println("**** Issue here **** - the next four lines should be the mqtt broker adress after changing in portal and restarting but apparently custom_mqtt_broker.getValue() never gets it value of the config.json");
Serial.println(String(custom_mqtt_broker.getValue()));
Serial.println(custom_mqtt_broker.getValue());
Serial.println(String(mqtt_broker));
Serial.println(mqtt_broker);
}
void loop()
{
loopDeviceWM();
} |
|
Why are you copying it back into the same variable though ?
|
|
you also should not be doing this much stuff in your callbacks, just set some flag and then save your spiffs later. |
this is just done in setup... "mqtt_broker" is always alright. it behaves perfectly even when i put it in the code... but when i enter the configportal > setup it shows the first value it had and the changes are not reflected there... if i could just put something like "custom_mqtt_broker = mqtt_broker" everything would work :) . if i comment that out nothing is updated... the callback also works fine i think. the config.json reflects everything i change. otherwise "strcpy(mqtt_broker, jsonBuffer["mqtt_broker"]);" would not work. its just the UI thats unusable because it will always say "192.168.100.108" even if i change it in the configportal while on wifi. |
|
Looks fine to me *WM: [1] Starting Web Portal
*WM: [3] dns server started with ip:
*WM: [2] HTTP server started
*WM: [2] WiFi Scan completed in 2182 ms
**** Issue here **** - the next four lines should be the mqtt broker adress after changing in portal and restarting but apparently custom_mqtt_broker.getValue() never gets it value of the config.json
192.168.100.108
192.168.100.108
192.168.100.108
192.168.100.108
*WM: [2] <- HTTP Root
*WM: [3] -> 192.168.1.84
*WM: [3] lastconxresult: WL_CONNECTED
*WM: [2] WiFi Scan completed in 2183 ms
*WM: [2] <- HTTP Param
*WM: [3] lastconxresult: WL_CONNECTED
*WM: [3] Sent param page
*WM: [2] <- HTTP WiFi save
*WM: [3] Method: POST
*WM: [2] Parameters
*WM: [2] --------------------
*WM: [2] mqttbroker: 192.168.100.112
*WM: [2] --------------------
****************Should save params
192.168.100.108
192.168.100.112
192.168.100.112
192.168.100.112
{"mqtt_broker":"192.168.100.112"}*WM: [3] Sent param save page I had to remove spiffs, it was crashing my esp, maybe your problem is with spiffs.. Not really understanding what you are trying to do though.. Is this a typo? because that doesn't make sense, wm params have nothing to do with json.. they are whatever you set them to or what you submit them as in the http get request. |
|
yes... it works so far... if you restart the esp now it does not anymore and it gets extremly close to working if i put: |
|
If it is not set after resetting then you are not reading it from spiffs properly and then setting it.. |
but it is set properly... restart it after you did what you just did. and then enter the portal on the wifi, go to setup... now you will still see 192.168.100.108 and not 192.168.100.112 while the value of mqtt_broker is correctly 192.168.100.112. here it is with the answer from above - no change: |
|
I cannot test that part, my spiffs is not working, reread my previous port I edited it. you know you can init a param without a value and then set value later ? your code just does this over and over on every restart, why would the value change ? |
|
oops I commented out the spiffs part I see it now Yeah so my guess is you are reading this in wrong into the same var[16] char, you need to not do that, as mentioned above. |
I am curious is it corrupt only after submitting and getting it? Or is this also corrupt ? |
|
if i dont do
|
|
interesting |
|
oh sorry, I have that commented out, do not do // if(setupSpiffs() == 0){ Just set and get the param value, that is all |
|
Then change this then change your spiffs restore to Sorry it took me like 30 minutes and 2 reboots to get my damn serial ports working, and now I have to format spiffs to actually run your code. |
heyhey.... its completly amazing that there is somebody out there... i sunk about 20 hours in this now and it feels truly heartwarming that you are taking care... so i changed my code to this but i still have the same outcome: |
|
Do you know how to init format spiffs? |
|
nm, // SPIFFS.format(); |
|
And you have the same problem with the autoconnectwithparams example? |
|
in the mean time use setValue, it has something to do with calling WiFiManagerParameter twice and it not setting the or overriding the first obj memory properly This should work fine, adjust length to match whatever you set it to before etc. |
|
So here is the reproduction char mqtt_broker[] = "192.168.100.108";
WiFiManagerParameter custom_mqtt_broker("mqttbroker", "MQTT Broker", mqtt_broker, 20);
void setup()
{
Serial.begin(115200);
delay(3000);
Serial.println("custom_mqtt_broker FIRST");
Serial.println(String(custom_mqtt_broker.getValue()));
custom_mqtt_broker = WiFiManagerParameter("mqttbroker", "MQTT Broker", mqtt_broker, 20);
Serial.println("custom_mqtt_broker SECOND");
Serial.println(String(custom_mqtt_broker.getValue()));
custom_mqtt_broker.setValue(mqtt_broker, 20);
Serial.println("custom_mqtt_broker THIRD");
Serial.println(String(custom_mqtt_broker.getValue()));
wm.addParameter(&custom_mqtt_broker);
}
....
custom_mqtt_broker FIRST
192.168.100.108
custom_mqtt_broker SECOND
P�<-- garbage memory
custom_mqtt_broker THIRD
192.168.100.108
*WM: [3] allocating params bytes: 20
*WM: [2] Added Parameter: What I don't understand is why setvalue is fine, and calling the constructor again is not, while they both internally call setValue and memset the same.. |
tablatronix
added
Discussion
|
Maybe someone can look at this for me and help me fix it or understand wtf is going on in the param class or with constructors, it should be the same memory, and if I check the ID its the same object.. |
hmm ok so something I do not understand about constructors.. NOT the same memory.. |
|
WiFiManagerParameter is missing a copy assignment operator. https://en.cppreference.com/w/cpp/language/copy_assignment Doing this: is different from doing this: what happens in that single line is this:
Hope that clarifies... Is there any reason you want re-assign custom_mqtt_broker? Some comments are in German and although I got taught German at school 25 years ago it's not that good anymore... |
|
Thanks, Yeah I was reading about correct assignment but did not really understand what it meant. I am mostly curious how to handle this, how to make it work as expected or prevent it. As it is something users are going to try. I have some reading to do on c++ |
|
I agree that users will try to do this so we must prevent users from doing it or add the required code to handle it. I will make a pull request to handle this. |
|
Maybe it's better to deny coping of WiFiParameter and add function "setValue()"? |
|
We have setValue and we can also check _id and deny I can throw a compiler error. It would be cool to just allow it though if its not too much trouble. At this point I really want to see how , there is also already an init helper in the constructor so maybe we can do something with that to reinit safely |
|
So is this correct or the gist? Not sure if rhs is ref or pointer, I will wait for an actual PR from someone more confident in this than I, But I am trying to learn lol WiFiManagerParameter& operator=(const WiFiManagerParameter& rhs);
...
WiFiManagerParameter& WiFiManagerParameter::operator=(const WiFiManagerParameter& rhs){
(*this->_value) = (*rhs._value);
// other stuff, copy other vars? _id etc
return *this;
}Does this leak memory though? Also I am not sure we are cleaning up this in the deconstructor properly. |
|
We could use
Somebody will always find a reason :) |
|
I found the reason: More code, more bugs. Here is one of them: We have memory leak if call setValue() in our program. @tablatronix i think: |
|
I like this one better:
That will be deleted again in the destructor The copy assignment could be further optimized by using move semantics. @dontsovcmc Perhaps you made a good point, just prevent copy assignment in the first place? That will show also good design methodology for embedded software developers. |
|
@rvt "That will be deleted again in the destructor." |
|
@dontsovcmc yes you are absolutely right, setValue does not release memory of previously allocated memory... I guess that´s why we love immutables :) |
|
@tablatronix @rvt
I have to admit that i did not know about setValue() and never stumpled upon it in my extensive research. I am just wondering why this is considered a "meantime"-solution since it does exactly what i needed? is it not optimal to solve it like that? i am sorry for the german comments... i changed them to english. but no.... there was no particula reason to redeclare it - i just tried so much and this was the only thing that produced some kind of meaningful return. also: the working sketch for anybody making it down here: |
|
Thanks all, yeah that is why I asked if this would leak memory, I assumed it would from the NEW value each time if there was any destruction allowed via assignment. Ill let you all discuss this a little |
|
Made copy assignment private, so compiler will error out if you try this again. Leaving open for improvements or alternatives. |
Not sure what compiler you are using but with c++11 you can do this: so you don't have to set it private if you just want to prevent all users (including the class self) prevent using the copy assignment. |
|
ooh |
|
Hello, I am curently using .setValue() But my question is, is this now safe to use? Forgive my ignorance. I have read the post 1050 / 1341 and 1346. But I cannot understand if the memory leak issue is now gone or not? In my case I always restart after going to the configportal (because, when returning from configportal i have to go back to an assync webserver, and that only works with a restart, since the cleanup from the wm webserver leaves "stuff behind") But in anycase, it would be kind if you can let me know if the .setValue() is now leak safe. Best Regards to Tablatronix! Thank you so much for making this wifimanager something that we can use daily. |
|
This is 2 years old, so no idea, pretty sure there have been at least 2 PRs to this |
Basic Infos
Hardware
WiFimanager Branch/Release:
Esp8266/Esp32:
Hardware: ESP-12e, esp01, esp25
ESP Core Version: 2.4.0, staging
Description
Hi,
When we add a custom WiFiManagerParameter with a normal char* to initialize the default value it has a strange conversion error. Following code:
puts out on the Serial:
Settings in IDE
Module: NodeMcu, Wemos D1
Additional libraries:
Sketch
mounted file system
Configure WiFireading config file
opened config file
{"output":"2","mqtt_broker":"192.168.1.108","mqtt_pwd":"","session_key":"","entity_name":"","entity_type":"","wifi_enc":"","entity_version":"","mqtt_port":"1883","entity_id":"","mqtt_retain":"","mqtt_qos":""}
parsed json
loaded Json
now mqtt broker is:
192.168.1.108
SO, NOW:
192.168.1.108
*WM: [3] allocating params bytes: 20
*WM: [2] Added Parameter: mqttbroker
*WM: [1]
Info
Setup
Update
Close
Erase
Restart
Exit
Setup mode...
*WM: [1] AutoConnect
*WM: [2] esp_wifi_set_country: US
*WM: [1] AutoConnect: ESP Already Connected
*WM: [3] STA static IP:
*WM: [2] setSTAConfig static ip not set, skipping
*WM: [1] AutoConnect: SUCCESS
*WM: [1] STA IP Address: 192.168.1.109
Connected to wifi network!
IOT_ESP_6184038
192.168.1.109
*WM: [1] Starting Web Portal
*WM: [3] dns server started with ip:
*WM: [2] HTTP server started
*WM: [2] WiFi Scan completed in 2182 ms
⸮⸮⸮?168.1.10
192.168.1.108
192.168.1.108
attempting connecting to mqtt
The text was updated successfully, but these errors were encountered: