Add CSS body classes for each page #1767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the additional function argument for getHTTPHead() includes a default argument for backwards compatibility with the API.
Allows easy styling of each page
Trying to avoid confusion between the class for the root level and the CSS ":root" pseudo-class
Avoids an extra space if a body class is set, but an empty string is passed to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds classes to the body element for each individual page, so that it's easier to style pages differently:
This is accomplished by modifying the
getHTTPHead()function to add an optionalStringargument for classes to add, and a set of constant class strings in thewm_constsheader. The class strings are then invoked in each respective route "handle" function when the head is generated.I did not add separate classes for the "saved" pages, as that seemed excessive. But I'm happy to go in and add them if you think it would be beneficial.
This change does not break the current API and should add minimal overhead.