Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis builds, add esp32 builds #570

Merged
merged 16 commits into from
Mar 20, 2018
Merged

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Mar 20, 2018

Use current arduino version in builds.
Add esp32 platform builds excluding two examples due to SPIFFS incompatibility:

  • "AutoConnectWithFSParametersAndCustomIP.ino"
  • "AutoConnectWithFSParameters.ino"

Disabled the "codecov.io" support as no coverage is generated.

@liebman
Copy link
Contributor Author

liebman commented Mar 20, 2018

That's odd, this ran correctly on my fork! I'll make a small change to try again.

https://travis-ci.org/liebman/WiFiManager/builds/356041054

@tablatronix tablatronix requested a review from tzapu March 20, 2018 21:30
@tablatronix
Copy link
Collaborator

I am not to hip on the travis, asking tzapu to sign off on this.
Looks good to me

@liebman
Copy link
Contributor Author

liebman commented Mar 20, 2018

Actually its failing correctly! on esp32 we get this:

/Users/chris.l/Arduino/libraries/WiFiManager/WiFiManager.cpp: In member function 'boolean WiFiManager::stopConfigPortal()':
/Users/chris.l/Arduino/libraries/WiFiManager/WiFiManager.cpp:582:20: error: expected primary-expression before ',' token
   if(!ret)DEBUG_WM(,DEBUG_ERROR,F("[ERROR] disconnect configportal - softAPdisconnect FAILED"));
                    ^

I just replicated this with an example in Eclipse/Sloeber by updating my fork form the current development branch.....

@tablatronix
Copy link
Collaborator

Sorry about that I forgot to push

@liebman
Copy link
Contributor Author

liebman commented Mar 20, 2018

Passed!!!!

@tablatronix
Copy link
Collaborator

Thats what happens when you code while watching youtube...

@tablatronix tablatronix reopened this Mar 20, 2018
@tablatronix tablatronix merged commit 6319955 into tzapu:development Mar 20, 2018
@tablatronix tablatronix added bug Validated BUG QA Quality Assurance testing needed labels Mar 20, 2018
@tablatronix tablatronix added this to the dev milestone Mar 20, 2018
@tablatronix tablatronix mentioned this pull request Mar 20, 2018
@tablatronix
Copy link
Collaborator

tablatronix commented Mar 20, 2018

#531
#521

@tablatronix tablatronix removed the request for review from tzapu March 20, 2018 22:52
@liebman liebman mentioned this pull request Mar 21, 2018
@tablatronix
Copy link
Collaborator

fix esp32 examples
7279333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Validated BUG QA Quality Assurance testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants