Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wifi Wait Callback #596

Closed
wants to merge 6 commits into from
Closed

Wifi Wait Callback #596

wants to merge 6 commits into from

Conversation

elliottkember
Copy link

When WifiManger is running the config portal, we currently don't have any control and can't make anything happen. We'd like to do some fun things to indicate current status, as well as escape the Wifi configuration step if we need to run offline. This change introduces a wifiWaitCallback that gets called every WiFi config portal loop.

@elliottkember
Copy link
Author

If the wifiWaitCallback returns true, we're exiting out of the AP setup to resume operation in offline mode.

@tablatronix
Copy link
Collaborator

Just use configportal non blocking and call process in your loop

@tablatronix
Copy link
Collaborator

although you can already do this
#500

I might merge this so you have 2 options.. I just think people will do something stupid in this loop and wonder why their portal isn't responding properly.

@elliottkember
Copy link
Author

Oh, thanks - I didn't know about the non-blocking mode because it's not in the documentation. I can understand not wanting to merge to keep this foolproof - a warning not to do anything slow in the loop might do the trick. I'd rather not use development branch so for now I'm using my fork off master and it's working great. Very useful to have some visual feedback on wifi connection state either way!

@tablatronix
Copy link
Collaborator

Yeah that issue is all that exists at the moment hopefully someone can help write some docs

@elliottkember
Copy link
Author

elliottkember commented Apr 27, 2018 via email

@tablatronix
Copy link
Collaborator

Pretty much, there are about 2 major features that need completion, 90% of it is already documented in the overview in #500 and the source is well documented.

@tablatronix
Copy link
Collaborator

tablatronix commented Apr 27, 2018

oh and I need to fix up examples
#531

@tablatronix
Copy link
Collaborator

Can you think of any reason to still require this?

@elliottkember
Copy link
Author

Not really — I switched to the asynchronous development branch and it's working great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants