Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route and frontName settings #4

Closed
MasyH opened this issue Feb 14, 2014 · 5 comments
Closed

route and frontName settings #4

MasyH opened this issue Feb 14, 2014 · 5 comments
Assignees

Comments

@MasyH
Copy link

MasyH commented Feb 14, 2014

Could you add a "route" setting that would override the use of the lowercased modulename, and a "frontName" setting that would allow independence with the route value ? Thank you !

@MasyH MasyH closed this as completed Feb 14, 2014
@MasyH MasyH reopened this Feb 14, 2014
@tzyganu
Copy link
Owner

tzyganu commented Feb 14, 2014

@MasyH Evem if this looks like a good(-ish) idea. I will not add it to the module. And here is why. Changing the frontName of a module can be easily done just by editing in config.xml the value of the frontName. Making it configurable will require some amount of code for validating the route name (so it won't conflict with other) and the added value of this is not that big. You can change it to whatever you want after creating and installing the module.

But I won't dismiss this completely. I will implement it when there is nothing else to do for the module. For sure it will not be in the first release. Thanks for the idea. I will leave this open for now but with low priority.

@tzyganu tzyganu self-assigned this Feb 14, 2014
@MasyH
Copy link
Author

MasyH commented Feb 14, 2014

Thank you for your response ! Yes, it's easy to change the frontName, and
yes it would not be that easy to validate the frontName conflicts.
Now, the other suggestion was to be able to configure the route, using it
in place of the lowercased modulename. This is by far NOT easy to change
after the module has been generated !
Suppose I already have a community module Xyz_Modulename and want to ceate
a local Abc_Modulename... So, I think that yes, the configurable frontName
is nice to have, but a configurable route name taking place of the
lowercased modulename would be a useful feature ! And the validating code
would be similar to the existing one. Thus not so "nice to have", and
probably easier to implement...
That said, I want to say that I discovered and tried UMC some days ago: it
is a wondeful module !!!! Thank you very much for that !

On Fri, Feb 14, 2014 at 1:09 PM, Marius notifications@github.com wrote:

@MasyH https://github.com/MasyH Evem if this looks like a good(-ish)
idea. I will not add it to the module. And here is why. Changing the
frontName of a module can be easily done just by editing in config.xmlthe value of the frontName. Making it configurable will require some amount
of code for validating the route name (so it won't conflict with other) and
the added value of this is not that big. You can change it to whatever you
want after creating and installing the module.

But I won't dismiss this completely. I will implement it when there is
nothing else to do for the module. For sure it will not be in the first
release. Thanks for the idea. I will leave this open for now but with low
priority.

Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-35078196
.

@MasyH
Copy link
Author

MasyH commented Feb 14, 2014

P.S. To be precise, the suggestion is not to just have the requests
rerouted, but to have ALL the module resources using the route name where
the lowercased modulename is used... thus, it would appear in folder names, etc etc.

And It does not always depend on you to decide the module naming conventions...

On Fri, Feb 14, 2014 at 1:25 PM, Hugues Masy hugues.masy@gmail.com wrote:

Thank you for your response ! Yes, it's easy to change the frontName, and
yes it would not be that easy to validate the frontName conflicts.
Now, the other suggestion was to be able to configure the route, using it
in place of the lowercased modulename. This is by far NOT easy to change
after the module has been generated !
Suppose I already have a community module Xyz_Modulename and want to ceate
a local Abc_Modulename... So, I think that yes, the configurable frontName
is nice to have, but a configurable route name taking place of the
lowercased modulename would be a useful feature ! And the validating code
would be similar to the existing one. Thus not so "nice to have", and
probably easier to implement...
That said, I want to say that I discovered and tried UMC some days ago: it
is a wondeful module !!!! Thank you very much for that !

On Fri, Feb 14, 2014 at 1:09 PM, Marius notifications@github.com wrote:

@MasyH https://github.com/MasyH Evem if this looks like a good(-ish)
idea. I will not add it to the module. And here is why. Changing the
frontName of a module can be easily done just by editing in config.xmlthe value of the frontName. Making it configurable will require some amount
of code for validating the route name (so it won't conflict with other) and
the added value of this is not that big. You can change it to whatever you
want after creating and installing the module.

But I won't dismiss this completely. I will implement it when there is
nothing else to do for the module. For sure it will not be in the first
release. Thanks for the idea. I will leave this open for now but with low
priority.

Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-35078196
.

@tzyganu
Copy link
Owner

tzyganu commented Feb 14, 2014

@MasyH I understood that you want all the module resources to use the route name.
But I wan't to mention that there is already a restriction. If you have a module called Xyz_Modulename installed you won't be able tor create a module Abc_Modulename. I plan to remove this restriction by changing the models (and blocks and helpers) aliases from module/something to namespace_module/something. Then you won't have any conflicts for class names. I will do that as soon as I have everything else working. Then, for sure I will need a way to check for routes conflicts and I may be forced to implement what you are suggesting. But like I said...Not in the first release. Feel free to create a pull request if you can. I'm working on this all by myself (PM, developer, tester). I could really use an additional set of hands and a brain on this.

@tzyganu
Copy link
Owner

tzyganu commented Mar 26, 2014

This should be fixed in version 1.9-dev8. You can review it and tell me if it's what you've hoped it will be.

@tzyganu tzyganu closed this as completed Mar 26, 2014
tzyganu pushed a commit that referenced this issue Jun 9, 2016
Compressed the base64 encoded 404 image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants