-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for database file storage #75
base: master
Are you sure you want to change the base?
Conversation
@mikeschaekermann Thanks for the kind words and the pull requests. I will review them as soon as possible and merge them if I don't find any issues. I already took a look at the mass copy to store view aciton and I think something is wrong (I'm not exactly sure, I just want to get this by you). Does the |
…w in a new tab; for each store view, the entity is available for, one link is added;
@tzyganu thanks for looking into the pull request so quickly. You're right. The code is not cleanly encapsulated for FLAT + NOT TREE entities only. This is true for both the preview feature and the mass copy feature. In the umc_source.xml I was looking for depend statements that would help me to further specify for what kinds of entities individual changes should be applied. The ones I found were:
I think I will need your assistance here. How can I distinguish between "Enable by stores: YES/NO" entities in umc_source.xml? |
@mikeschaekermann At a first glance I think that what you are looking for is So if you add an other file the |
@tzyganu thank you! This should be sufficient in order to restrict the mass copy to store view feature to entites of type FLAT + NOT TREE + ENABLED BY STORE. For the preview feature, I would like to have two different files for ENABLED BY STORE: YES and NO. Hence, my question: is there an inverse option of |
…NOT TREE + ENABLED BY STORE
@tzyganu for the preview feature, I would like to have two different files for ENABLED BY STORE: YES and NO. Is there an inverse option of store, e.g. something like not_store? |
You can add a new method in
then you can use the condition in xml like |
Oh nice! Thanks for that hint! |
Actually, there already seems to be a method fulfilling that purpose: /**
* check if the entity is not store related
*
* @access public
* @return bool
* @author Marius Strajeru <ultimate.module.creator@gmail.com>
*/
public function getNoStore()
{
return !$this->getStore();
} |
@tzyganu , we are making use of your UMC in our e-commerce company a lot. So first of all, thanks for creating this awesome and very helpful resource! Today, I will file some pull requests of contributions that we would like to offer from our time working with the extension. The first contribution is support for database file storage. We tested it in production and, for us, it worked fine!