Tweak #283
Merged
Tweak #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using -E on sudo causes sudo to fail in odd ways, on certain systems. Stop using -E and do more to craft Cmd.Env before running the programs. Signed-off-by: the man <rminnich@google.com>
Signed-off-by: the man <rminnich@google.com>
os.Get[ug]id can do more than is wanted on some systems. cpuns needs the rawest possible result. Signed-off-by: the man <rminnich@google.com>
binjip978
reviewed
Sep 27, 2024
Users might not be able to install cpuns in the limited set of paths sshd looks in. Add a switch, cpuns, to allow them to indicate the proper location. This works: cpu -cpuns ~/go/bin/cpuns -nfs=true -namespace="" -sp 22 -key ~/.ssh/id_rsa a3mega-a3meganodeset-0 Don't stress about all the switches: they can be easily set in .ssh/config Signed-off-by: the man <rminnich@google.com>
Signed-off-by: the man <rminnich@google.com>
change all v to verbose, so we get the CPUNS: prefix. some sudo will not blindly accept all environment variables with -E, but will let us save a select few. CPU_FSTAB seems to be acceptable. We want to save CPU_FSTAB in the environment so it is not exposed in argv, as it would be if we added it to the environment variables preserved with -env, since it exposes the port and the mount GUID. At this point, with an extremely picky sudo, cpuns works fine. Signed-off-by: the man <rminnich@google.com>
Signed-off-by: the man <rminnich@google.com>
|
testing: linux -> linux with sshd and having to run sudo cpuns |
binjip978
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.