Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if adding a package fails. #73

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

Prabhuk
Copy link
Contributor

@Prabhuk Prabhuk commented Jun 6, 2022

Current behavior allows for the build to continue if adding a package fails. Modifying the behavior to fail fast to identify the build failures.

@10000TB
Copy link
Member

10000TB commented Jun 6, 2022

for the DCO failure, try run this git commit --amend --signoff and then force push, which include a sign off line in your commit message

10000TB
10000TB previously approved these changes Jun 6, 2022
src/pkg/bb/findpkg/bb.go Outdated Show resolved Hide resolved
Signed-off-by: Prabhu Rajasekaran <prabhukr@google.com>
@hugelgupf hugelgupf merged commit 36fb46b into u-root:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants