use BuildTags in find package step #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's time to drop 1.15 and 1.16? the failure is not related to this code at all. |
|
Do you still need this? Looks like it might be useful. Could you add a tinygo test? |
If a user sets, e.g., -tags tinygo, that tag must be used in the loadPkgs step, as well as the build step, else directories will be populated with files that can not be used. Example: if we run u-root -tags tinygo files are copied to the build directory that should not be, and build steps will get an error. With this change, tags will control both the file copy step as well as the build step. Signed-off-by: Ronald G. Minnich <rminnich@google.com>
hugelgupf
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user sets, e.g., -tags tinygo, that tag must be used in the loadPkgs step, as well as the build step, else directories will be populated with files that can not be used.
Example: if we run
u-root -tags tinygo
files are copied to the build directory that should not be, and build steps will get an error.
With this change, tags will control both the file copy step as well as the build step.
Signed-off-by: Ronald G. Minnich rminnich@google.com