various type fixes #1307

Triggered via push August 29, 2024 12:55

goto-bus-stop

pushed 8362576

sql-db

Status Failure

Total duration 1m 16s

Artifacts –

ci.yml

on: push

Matrix: Tests

Annotations

29 errors and 10 warnings

Types: src/SocketServer.js#L395

Argument of type '{ _id: UserID; username: string; slug: string; roles: string[]; avatar: string | null; activePlaylist: string | null | undefined; createdAt: string; updatedAt: string | undefined; }' is not assignable to parameter of type 'JsonValue'.

Types: src/controllers/authenticate.js#L52

Argument of type 'User & { id: UserID; username: string; slug: string; avatar: string | null; activePlaylistID: PlaylistID | null; pendingActivation: boolean; createdAt: Date; updatedAt: Date; }' is not assignable to parameter of type '{ id: UserID; username: string; slug: string; roles: string[]; avatar: string | null; activePlaylistID?: string | null | undefined; createdAt: Date; updatedAt?: Date | undefined; }'.

Types: src/controllers/authenticate.js#L359

Argument of type '{ id: UserID; username: string; slug: string; avatar: string | null; activePlaylistID: PlaylistID | null; pendingActivation: boolean; createdAt: Date; updatedAt: Date; }' is not assignable to parameter of type '{ id: UserID; username: string; slug: string; roles: string[]; avatar: string | null; activePlaylistID?: string | null | undefined; createdAt: Date; updatedAt?: Date | undefined; }'.

Types: src/controllers/booth.js#L64

Type 'Promise<string | null>' is not assignable to type 'Promise<UserID | null>'.

Types: src/controllers/booth.js#L323

Property 'media' does not exist on type '{ size: number; id: PlaylistID; createdAt: Date; updatedAt: Date; userID: UserID; name: string; }'.

Types: src/controllers/booth.js#L331

Property 'save' does not exist on type '{ size: number; id: PlaylistID; createdAt: Date; updatedAt: Date; userID: UserID; name: string; }'.

Types: src/controllers/booth.js#L335

Property 'media' does not exist on type '{ size: number; id: PlaylistID; createdAt: Date; updatedAt: Date; userID: UserID; name: string; }'.

Types: src/controllers/booth.js#L362

Type '{ 'media.media': MediaID; }' has no properties in common with type '{ offset?: number | undefined; limit?: number | undefined; }'.

Types: src/controllers/now.js#L15

Property 'size' does not exist on type '{ id: PlaylistID; createdAt: Date; updatedAt: Date; userID: UserID; name: string; }'.

Types: src/controllers/now.js#L17

Argument of type '{ id: PlaylistItemID; mediaID: MediaID; artist: string; title: string; start: number; end: number; createdAt: Date; updatedAt: Date; }' is not assignable to parameter of type '{ id: PlaylistItemID; playlistID: PlaylistID; mediaID: MediaID; artist: string; title: string; start: number; end: number; createdAt: Date; updatedAt: Date; }'.

Code style: src/Uwave.js#L7

Expected a line break after this opening brace

Code style: src/Uwave.js#L7

'PostgresDialect' is defined but never used

Code style: src/Uwave.js#L7

Expected a line break before this closing brace

Code style: src/Uwave.js#L36

Unexpected space before function parentheses

Code style: src/Uwave.js#L45

Missing '()' invoking a constructor

Code style: src/Uwave.js#L47

Unexpected space before function parentheses

Code style: src/Uwave.js#L54

Expected blank line between class members

Code style: src/Uwave.js#L66

Expected blank line between class members

Code style: src/Uwave.js#L66

Unexpected space before function parentheses

Code style: src/Uwave.js#L106

for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array

Tests (20.x, 6.0)

Process completed with exit code 1.

Tests (lts/*, 5.0)

The job was canceled because "_20_x_6_0" failed.

Tests (lts/*, 5.0)

Process completed with exit code 1.

Tests (20.x, 7.0)

The job was canceled because "_20_x_6_0" failed.

Tests (20.x, 7.0)

Process completed with exit code 1.

Tests (18.x, 6.0)

The job was canceled because "_20_x_6_0" failed.