Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop non-recurring events immediately if out-of-range #213

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Drop non-recurring events immediately if out-of-range #213

merged 1 commit into from
Mar 23, 2019

Conversation

marcelstoer
Copy link
Contributor

Fixes #207

@marcelstoer
Copy link
Contributor Author

@u01jmg3 you adding the to-be-tested label reminded me that I was missing unit or integration tests when I first started tinkering with this library. I could never be sure I wasn't breaking other features. Do you have your own test rig somewhere?

@u01jmg3
Copy link
Owner

u01jmg3 commented Mar 22, 2019

I do but once PR #209/#210/#211 are merged there will be a better method of contributing tests.

@u01jmg3 u01jmg3 merged commit 6073038 into u01jmg3:master Mar 23, 2019
u01jmg3 added a commit that referenced this pull request Mar 23, 2019
u01jmg3 added a commit that referenced this pull request Mar 23, 2019
Coding standards
u01jmg3 added a commit that referenced this pull request Mar 23, 2019
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Mar 23, 2019
@u01jmg3
Copy link
Owner

u01jmg3 commented Mar 28, 2019

@marcelstoer: if you fancy contributing a unit test for this PR that would be very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: further improve parsing large calendars for small windows
2 participants