Add error returns if command invalid in RunCommand in-toto#124

u5surf · Sep 11, 2021 · bfa1d8e · bfa1d8e
1 parent 02b98c8
commit bfa1d8e
Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/in_toto/runlib.go b/in_toto/runlib.go
@@ -240,6 +240,10 @@ command execution.
 */
 func RunCommand(cmdArgs []string, runDir string) (map[string]interface{}, error) {
 
+	if cmdArgs == nil || len(cmdArgs) == 0 {
+		return nil, errors.New("invalid command")
+	}
+
 	cmd := exec.Command(cmdArgs[0], cmdArgs[1:]...)
 
 	if runDir != "" {

diff --git a/in_toto/runlib_test.go b/in_toto/runlib_test.go
@@ -447,6 +447,8 @@ func TestInTotoRun(t *testing.T) {
 			KeyVal:              KeyVal{},
 			Scheme:              "",
 		}, []string{"sha256"}},
+		{[]string{"alice.pub"}, []string{}, nil, validKey, []string{"sha256"}},
+		{[]string{"alice.pub"}, []string{"foo.tar.gz"}, nil, validKey, []string{"sha256"}},
 	}
 
 	for _, table := range tablesInvalid {