Background redirects not blocked

[davidhedlund]

[Moved to https://github.com/gorhill/uBlock/issues/99]

[chrisaljoudi]

Please provide a specific test case where this occurs (popups not being blocked), and we can more appropriately diagnose the issue then.

[flyingzebras]

@chrisaljoudi

[also reported in https://forums.lanik.us/viewtopic.php?f=62&t=21495&p=69619#p69619]

The Pornhub NETWORK is full of popup redirects that appear in uBlock with EasyList enabled, but they are blocked by Adblock Plus. I'm not sure why Adblock Plus and uBlock behave different in this regard but maybe you know?

Pornhub NETWORK domains with popups:
pornhub.com
redtube.com
youporn.com
tube8.com
pornmd.com
spankwire.com
keezmovies.com
xtube.com
extremetube.com
gaytube.com

[gorhill]

@flyingzebras What browser/version? This is important to mention.

[flyingzebras]

@gorhill IceCat 31.6.0 (based on Firefox ESR 31.6.0).

[gorhill]

@flyingzebras You also need to provide URLs from where the popups occur. The first thing to do for a dev is to reproduce the problem, without this, no fix possible. You enumerate URLs of popups, but from where did you get them?

[gorhill]

full of popups that appear in uBlock with EasyList enabled, but they are blocked by Adblock Plus

I am skeptical of this. I tested one site, and I did get a "popunder" (which is also an issue for ABP). However, it happens only once, apparently the site sets a cookie and once this cookie is present it won't trigger another popup. Try your test again with ABP but first clear all the cookies for the site, and then open a page where the popups occur. If uBlock and ABP have the same filter lists enabled, there won't be more popups with uBlock, or less popups with ABP.

The popup blocker in uBlock is pretty solid, it passes tests that ABP won't pass, for example, ABP fails 9. and 10. here. So it's all in the filters, and it's also how you conduct your tests: you may get a popup with the first blocker you test, then no popup with the other one on the same page, because the page sets cookies (probably to delay the next popup, to not badger the users with too many popups.)

[gorhill]

The ones you encounter are probably the popunder ones, which are not currently blocked by ABP or uBlock:

uBlock: gorhill/uBlock#99
ABP: https://issues.adblockplus.org/ticket/2095

[gorhill]

You can't block popunder currently, that's why it still is an open issue.

[flyingzebras]

Popup domain: tube8.com
Popup URL: http://www.casino.com/sv/media/wide_200p/slots/bonus_bears/?b=med_200p&SID=209518&p=1
Popup position: left tab

[gorhill]

I tried tube8.com, and a popup to ebocornac.com was blocked, by filter |http://*?id=$domain=tube8.com. So it seems to me the URL of your popup is not matched by EasyList, this is something you should report to EasyList maintainers.

[flyingzebras]

@gorhill I would really appreciate if you participated in https://forums.lanik.us/viewtopic.php?f=62&t=21495&p=69619#p69619

[gorhill]

Looking at it, your popup with URL http://www.casino.com/sv/media/wide_200p/slots/bonus_bears/?b=med_200p&SID=209518&p=1 should have been blocked by filter |http://*?*=*&$popup,third-party,domain=tube8.com in EasyList. Are you saying that popup was not blocked by uBlock? If so, you will have to enumerate your filter lists, your custom filters, whether dynamic filtering is enabled, and if so what rules are in use on tube8.com, also, your whitelist directives.

[gorhill]

@flyingzebras You are making this very difficult by not focusing on a very specific issue, and by not providing information only on what I am asking here. So please, focus only on this:

Your issue:

• URL: tube8.com
• URL of not blocked popup: http://www.casino.com/sv/media/wide_200p/slots/bonus_bears/?b=med_200p&SID=209518&p=1

Can you confirm this is your issue?

If so, please provide the details I asked above, and only these. All else is noise making the whole thing very confusing to follow.

[flyingzebras]

@gorhill:

URL: tube8.com
URLs of unblocked popups:
ebocornac.com/fp.engine?id=b170c29d-8fd6-4237-bba5-ccbdf691c081&rand=24598&ver=asynch&time=-120&referrerUrl=http%3A%2F%2Fwww.tube8.es%2F&subId=&abr=true&hosted=true
which redirects to
https://casino-x.com/?partner=p13186p24926p73de&promo=cx_doublepimp_main_white_se_Tube8

[gorhill]

If so, you will have to enumerate your filter lists, your custom filters, whether dynamic filtering is enabled, and if so what rules are in use on tube8.com, also, your whitelist directives.

[flyingzebras]

@gorhill I'm using uBlock 0.9.1.0 with default settings ("Reset to default settings..." clicked) with updated filter lists ("Update now" in 3rd-party filters clicked).

[gorhill]

IceCat 31.6.0 ... uBlock 0.9.1.0

As said, I can't reproduce your issue, popups are blocked when I try to reproduce. However that is with latest release of uBlock and latest release of Firefox.

[gorhill]

https://github.com/chrisaljoudi/uBlock/releases

[davidhedlund]

@gorhill What is the difference between
https://addons.mozilla.org/en-US/firefox/addon/ublock/ and
https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ ?

[gorhill]

Off the top of my head, as of writing, mostly:

• Per-site switches only in uBlock Origin
• A feature specific to Firefox not in uBlock Origin -- you can launch element picker from page inspector
• uBlock Origin still suffer from the disable remote fonts bug, fixed in uBlock
• From what I see from @AlexVallat's work, uBlock will be properly supported on legacy Firefox-based browsers soon (I haven't decided if I will import this work in uBlock Origin -- I am leaning toward not importing this currently: that one version of uBlock is well supported on these older browsers seem sufficient to me)

That's what comes to mind. Otherwise all is the same, no difference in performance (I have seen this claimed in the Firefox's AMO, it's baseless).

[gorhill]

@flyingzebras

I see now why https://casino-x.com/?partner=p13186p24926p73de&promo=cx_doublepimp_main_white_se_Tube8 was not blocked: the filter in EasyList works for URLs which starts with http:, however the casino-x.com URL (as you report) starts with https:. So this is the issue, the filter in EasyList needs to address this.

[davidhedlund]

@gorhill What is the purpose of uBlock Origin?

Why not just add these features to uBlock for Firefox without enable them (the GNU filters are not enabled in uBlock Origin by the way)?

[alejandrolemus]

@davidhedlund

What is the difference between...
What is the purpose of uBlock Origin?

https://github.com/gorhill/uBlock, scroll down to readme.md

[davidhedlund]

@alejandrolemus Thank you.

[ryanbr]

Does this commit help?

https://hg.adblockplus.org/easylist/rev/caf7f8754562

[flyingzebras]

@ryanbr No.