-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windowsreport.com: ads #26671
Comments
@gorhill Hmm... weird, this filter /^https:\/\/[0-9a-f]{10}\.[0-9a-f]{10}\.com\/[0-9a-f]{32}\.js$/$script,3p,to=com works in Firefox but somehow the regex not matched in chromium? Happens in uBO chromium as well If I change the /^https:\/\/[0-9a-f]{10}\.[0-9a-f]{10}\.com\/[0-9a-f]{32}\.js\b/$script,3p,to=com |
Need to investigate. I stepped into the code and I can see the regex internally is
Never mind, it is blocked when supplying the proper context:
However it's not blocked as per logger. Never mind again, it is blocked according to the logger: So not sure why it didn't work on your side. In uBOL it might not work though because the regex might be rejected by the DNR API, it should be shown in the dev tools console if so. |
Hmm... When I checked the |
The regex is a valid RE2 regex, so it passes the compile-time test and a rule is created for it. However there is a further test at run-time using Unfortunately |
Ah I see, I always thought About browser-dependent, is it different depending on users' machine power as well, or all chromium browsers would be the same? If it's the former, that would be really difficult to evaluate the filters. |
I expect all Chromium-based browsers would be the same, but since it's currently implementation-dependent and not API-dependent, there is no 100% guarantee. It's the reason for the webextensions issue I linked above, to make it easier for extension authors to figure out at rule compile-time what is a valid regex and what is not, but beside a bit of talk about it in August 2023, nothing has moved forward. |
Prerequisites
Complete
filtering mode.URL address of the web page
https://windowsreport.com/how-to-stop-microsoft-edge-from-screenshots/
Category
ads
Description
ads
Other extensions used
no
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: