Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTM scripts blocked despite having the website added to the nofiltering list #247

Open
7 tasks done
ugo-zaber opened this issue Nov 21, 2024 · 3 comments
Open
7 tasks done

Comments

@ugo-zaber
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality by using the chat icon in the popup panel.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO Lite in the browser.

I tried to reproduce the issue when...

  • uBO Lite is the only extension.
  • using a new, unmodified browser profile.

Description

Hi,

We use GTM scripts on our websites and we noticed that even when the URL is added to the nofilter rule, the scripts are being blocked. The console gives an error "net::ERR_ABORTED 504 (Gateway Timeout)". If ublock lite is disabled, everything loads correctly. I tried whitelisting subdomains, googletagmanager.com etc ... and nothing helps.

A specific URL where the issue occurs.

https://www.zaber.com

Steps to Reproduce

  1. Go to https://www.zaber.com
  2. Enable the developer move (F12)
  3. Disable all filtering (slider all the way to the left)
  4. Refresh website and witness the scripts being blocked.
  5. Now disable the ublock lite entire and refresh, the scripts are now allowed

Expected behavior

GTM shouldn't be blocked when the app is allowing trackers for unfiltered websites.

Actual behavior

GTM scripts are blocked on whitelisted websites.

uBO Lite version

2024.11.20.858

Browser name and version

Google Chrome 131.0.6778.71

Operating system and version

Windows 11 23H2

@gorhill
Copy link
Member

gorhill commented Nov 21, 2024

Unfortunately, there is no solution for this given how DNR works.

All content blockers suffers this issue, which is that if a network request is made from a worker, it will not be subjected to the allowAllRequests DNR rule used to prevent a site from being subjected to block rules.

The network requests being blocked despite no-filtering mode enabled for zaber.com all come from service workers.

@Yuki2718
Copy link

Yuki2718 commented Dec 9, 2024

This seems to be a serious issue. When user whitelisted a site, he and us assume ALL the requests will be allowed, this is the whole point of the whitelist.

@gorhill
Copy link
Member

gorhill commented Dec 9, 2024

One way to fix this issue would be to be able to completely exclude uBOL from acting on the site.

Unfortunately, browsers do not have a match-all/exclude-some approach to host permissions. allowAllRequests is not sufficient, there need to be the ability to exclude top origins though permissions API.

If this was possible, this would even render allowAllRequests unnecessary, and would simplify quite a lot disabling filtering on a site, since filtering also involves injecting scripts beside DNR rules.

gorhill added a commit to gorhill/uBlock that referenced this issue Dec 20, 2024
Related issue:
uBlockOrigin/uBOL-home#247

Use session rules with `TAB_ID_NONE` to properly exclude network
requests from service workers potentially used by trusted websites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants